Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2779693004: [Merge] Fix minidump-related JobScheduler test failures. (Closed)

Created:
3 years, 8 months ago by Ilya Sherman
Modified:
3 years, 8 months ago
Reviewers:
gone
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Merge] Fix minidump-related JobScheduler test failures. BUG=694884 TEST=none R=dfalcantara@chromium.org Review-Url: https://codereview.chromium.org/2753173002 Cr-Commit-Position: refs/heads/master@{#457650} (cherry picked from commit 0c77af249cab19e99fc0024b828373b1751633e2) Review-Url: https://codereview.chromium.org/2779693004 . Cr-Commit-Position: refs/branch-heads/3029@{#460} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/2159626e1e7064876a3f9dc1c420b721f9aac1c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionRunnableTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
Ilya Sherman
Committed patchset #1 (id:1) manually as 2159626e1e7064876a3f9dc1c420b721f9aac1c2.
3 years, 8 months ago (2017-03-28 21:21:43 UTC) #2
Ilya Sherman
3 years, 8 months ago (2017-03-29 04:00:02 UTC) #3
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2783833002/ by isherman@chromium.org.

The reason for reverting is: Caused a build failure: crbug.com/706254.  The
tests need to be updated to use the old way of testing a Feature..

Powered by Google App Engine
This is Rietveld 408576698