Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 2783513002: MD Settings: Display error messages in "add" and "edit" exception dialogs. (Closed)

Created:
3 years, 9 months ago by dpapad
Modified:
3 years, 8 months ago
Reviewers:
dschuyler
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Display error messages in "add" and "edit" exception dialogs. BUG=657639 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2783513002 Cr-Commit-Position: refs/heads/master@{#460868} Committed: https://chromium.googlesource.com/chromium/src/+/5046f55745940bd248cb51c38d45e7ff39cc75f3

Patch Set 1 #

Patch Set 2 : Add tests. #

Patch Set 3 : Fix typo." #

Patch Set 4 : Merge conflicts. #

Patch Set 5 : Remove left overs. #

Patch Set 6 : Remove left overs (again) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -7 lines) Patch
M chrome/browser/resources/settings/site_settings/add_site_dialog.html View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/add_site_dialog.js View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/edit_exception_dialog.html View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/edit_exception_dialog.js View 2 chunks +15 lines, -1 line 0 comments Download
M chrome/test/data/webui/settings/site_list_tests.js View 1 2 3 3 chunks +56 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 26 (17 generated)
dpapad
After screenshots at http://imgur.com/a/iLYPj.
3 years, 8 months ago (2017-03-28 23:35:30 UTC) #9
dschuyler
On 2017/03/28 23:35:30, dpapad wrote: > After screenshots at http://imgur.com/a/iLYPj. I still have the same ...
3 years, 8 months ago (2017-03-29 01:01:26 UTC) #14
dpapad
On 2017/03/29 at 01:01:26, dschuyler wrote: > On 2017/03/28 23:35:30, dpapad wrote: > > After ...
3 years, 8 months ago (2017-03-29 01:17:17 UTC) #15
bettes
On 2017/03/29 01:17:17, dpapad wrote: > On 2017/03/29 at 01:01:26, dschuyler wrote: > > On ...
3 years, 8 months ago (2017-03-29 22:30:52 UTC) #18
dschuyler
I've a preference for having the strings changed with this CL, but it's not a ...
3 years, 8 months ago (2017-03-29 22:50:19 UTC) #19
dpapad
On 2017/03/29 at 22:50:19, dschuyler wrote: > I've a preference for having the strings changed ...
3 years, 8 months ago (2017-03-30 17:53:38 UTC) #20
dpapad
On 2017/03/30 at 17:53:38, dpapad wrote: > On 2017/03/29 at 22:50:19, dschuyler wrote: > > ...
3 years, 8 months ago (2017-03-30 18:08:15 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783513002/100001
3 years, 8 months ago (2017-03-30 18:09:07 UTC) #23
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 20:53:20 UTC) #26
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/5046f55745940bd248cb51c38d45...

Powered by Google App Engine
This is Rietveld 408576698