Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2787053002: MD Settings: Change some instances of "Not valid" to "Not a valid web address". (Closed)

Created:
3 years, 8 months ago by dpapad
Modified:
3 years, 8 months ago
Reviewers:
dschuyler
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, srahim+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Change some instances of "Not valid" to "Not a valid web address". BUG=657639 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2787053002 Cr-Commit-Position: refs/heads/master@{#460875} Committed: https://chromium.googlesource.com/chromium/src/+/2b6c8430a8b66ce84ec2b4f6196c5332f407ea2a

Patch Set 1 #

Patch Set 2 : nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/app/settings_strings.grdp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/appearance_page/appearance_page.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/add_site_dialog.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/edit_exception_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (10 generated)
dpapad
3 years, 8 months ago (2017-03-30 18:10:05 UTC) #6
dschuyler
Thanks! lgtm
3 years, 8 months ago (2017-03-30 18:13:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787053002/20001
3 years, 8 months ago (2017-03-30 21:00:26 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 21:09:40 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2b6c8430a8b66ce84ec2b4f6196c...

Powered by Google App Engine
This is Rietveld 408576698