Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1159)

Issue 2783483003: Revert of Skip nullptr after copyToVector() from HeapHashSet<WeakMember> (Closed)

Created:
3 years, 8 months ago by kojii
Modified:
3 years, 8 months ago
Reviewers:
haraken, sof
CC:
ajuma+watch_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Skip nullptr after copyToVector() from HeapHashSet<WeakMember> (patchset #2 id:20001 of https://codereview.chromium.org/2723033002/ ) Reason for revert: Reverting because we have other fixes for the cause we suspected. See http://crbug.com/696231 for more details. Original issue's description: > Skip nullptr after copyToVector() from HeapHashSet<WeakMember> > > This patch checks and skips nullptr after copyToVector() from > HeapHashSet<WeakMember>. > > This is a speculative fix. > > BUG=581698, 689949, 696231 > > Review-Url: https://codereview.chromium.org/2723033002 > Cr-Commit-Position: refs/heads/master@{#453890} > Committed: https://chromium.googlesource.com/chromium/src/+/9dc4f6ff6d59eb2c27e3723a61e53f1430a9c192 TBR=haraken@chromium.org,sigbjornf@opera.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=581698, 689949, 696231 Review-Url: https://codereview.chromium.org/2783483003 Cr-Commit-Position: refs/heads/master@{#460142} Committed: https://chromium.googlesource.com/chromium/src/+/64bb332d22780352a0d2dbbd802d158aa9664af0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M third_party/WebKit/Source/core/css/CSSFontSelector.cpp View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontCache.cpp View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kojii
Created Revert of Skip nullptr after copyToVector() from HeapHashSet<WeakMember>
3 years, 8 months ago (2017-03-28 14:31:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783483003/1
3 years, 8 months ago (2017-03-28 14:31:52 UTC) #3
sof
lgtm
3 years, 8 months ago (2017-03-28 14:47:54 UTC) #4
haraken
LGTM
3 years, 8 months ago (2017-03-28 15:51:36 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 17:08:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/64bb332d22780352a0d2dbbd802d...

Powered by Google App Engine
This is Rietveld 408576698