Skip nullptr after copyToVector() from HeapHashSet<WeakMember>

Skip nullptr after copyToVector() from HeapHashSet<WeakMember>

This patch checks and skips nullptr after copyToVector() from
HeapHashSet<WeakMember>.

This is a speculative fix.

BUG=581698, 689949, 696231
Review-Url: https://codereview.chromium.org/2723033002
Cr-Commit-Position: refs/heads/master@{#453890}
Committed: https://chromium.googlesource.com/chromium/src/+/9dc4f6ff6d59eb2c27e3723a61e53f1430a9c192

[kojii, 2017-03-01 06:39:20]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 06:39:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-03-01 06:42:50]

Description was changed from

==========
weakchk

BUG=
==========

to

==========
Skip nullptr after copyToVector() from HeapHashSet<WeakMember>

This patch checks and skips nullptr after copyToVector() from
HeapHashSet<WeakMember>.

BUG=581698, 689949, 696231
==========

[kojii, 2017-03-01 07:32:03]

kojii@chromium.org changed reviewers:
+ haraken@chromium.org, sigbjornf@opera.com

[kojii, 2017-03-01 07:32:04]

PTAL. As per https://codereview.chromium.org/2725813002/#msg14 we prefer this
one.

[haraken, 2017-03-01 07:38:51]

LGTM but add a comment why we have the nullptr check.

[sof, 2017-03-01 07:40:08]

lgtm

if we prevent GCs during copyToVector()s, GC timings will be altered. This CL
allows us to pinpoint the cause first.

[kojii, 2017-03-01 07:46:05]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 07:46:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-03-01 07:46:46]

The CQ bit was unchecked by kojii@chromium.org

[kojii, 2017-03-01 07:48:02]

Thank you both for the great support. Let's hope this can give us a better
understanding.

On 2017/03/01 at 07:38:51, haraken wrote:
> add a comment why we have the nullptr check.

Done.

[kojii, 2017-03-01 07:51:01]

Description was changed from

==========
Skip nullptr after copyToVector() from HeapHashSet<WeakMember>

This patch checks and skips nullptr after copyToVector() from
HeapHashSet<WeakMember>.

BUG=581698, 689949, 696231
==========

to

==========
Skip nullptr after copyToVector() from HeapHashSet<WeakMember>

This patch checks and skips nullptr after copyToVector() from
HeapHashSet<WeakMember>.

This is a speculative fix.

BUG=581698, 689949, 696231
==========

[kojii, 2017-03-01 08:22:36]

The CQ bit was checked by kojii@chromium.org

[kojii, 2017-03-01 08:22:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, sigbjornf@opera.com
Link to the patchset: https://codereview.chromium.org/2723033002/#ps20001
(title: "Added comments (haraken's nit)")

[commit-bot: I haz the power, 2017-03-01 08:22:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 09:09:15]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488356556132830,
"parent_rev": "ced73dcd242b3c859323a03a2291d08e3c3f584a", "commit_rev":
"9dc4f6ff6d59eb2c27e3723a61e53f1430a9c192"}

[commit-bot: I haz the power, 2017-03-01 09:09:55]

Description was changed from

==========
Skip nullptr after copyToVector() from HeapHashSet<WeakMember>

This patch checks and skips nullptr after copyToVector() from
HeapHashSet<WeakMember>.

This is a speculative fix.

BUG=581698, 689949, 696231
==========

to

==========
Skip nullptr after copyToVector() from HeapHashSet<WeakMember>

This patch checks and skips nullptr after copyToVector() from
HeapHashSet<WeakMember>.

This is a speculative fix.

BUG=581698, 689949, 696231

Review-Url: https://codereview.chromium.org/2723033002
Cr-Commit-Position: refs/heads/master@{#453890}
Committed:
https://chromium.googlesource.com/chromium/src/+/9dc4f6ff6d59eb2c27e3723a61e5...
==========

[commit-bot: I haz the power, 2017-03-01 09:09:57]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9dc4f6ff6d59eb2c27e3723a61e5...

[sof, 2017-03-28 06:26:26]

Can we revert this one now?

[kojii, 2017-03-28 14:30:42]

Sorry I forgot, yes, let's do this.

Reverting because we have other fixes for the cause we suspected.

[kojii, 2017-03-28 14:31:26]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2783483003/ by kojii@chromium.org.

The reason for reverting is: Reverting because we have other fixes for the cause
we suspected. See http://crbug.com/696231 for more details..