Fetch Reading List favicon in the Controller

Fetch Reading List favicon in the Controller

This CL fetches the favicon for the Reading List item in the ViewController
instead of in the item.

BUG=705881
Review-Url: https://codereview.chromium.org/2783433004
Cr-Commit-Position: refs/heads/master@{#460322}
Committed: https://chromium.googlesource.com/chromium/src/+/28ea8191e57cf1a852a9e48f5298a3049687b006

[gambard, 2017-03-28 08:11:25]

gambard@chromium.org changed reviewers:
+ olivierrobin@chromium.org

[gambard, 2017-03-28 08:11:26]

PTAL.

[Olivier, 2017-03-28 13:02:35]

https://codereview.chromium.org/2783433004/diff/20001/ios/chrome/browser/ui/r...
File ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.mm
(right):

https://codereview.chromium.org/2783433004/diff/20001/ios/chrome/browser/ui/r...
ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.mm:356:
self.delegate = nil;
Should you remove the attribute somehow?

[gambard, 2017-03-28 13:11:44]

https://codereview.chromium.org/2783433004/diff/20001/ios/chrome/browser/ui/r...
File ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.mm
(right):

https://codereview.chromium.org/2783433004/diff/20001/ios/chrome/browser/ui/r...
ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.mm:356:
self.delegate = nil;
On 2017/03/28 13:02:35, Olivier Robin wrote:
> Should you remove the attribute somehow?

I have checked. For now it is not possible to pass nil as attribute to the
favicon view.
This CL does not modify the current behavior, but if the favicon fetch takes too
much time, a reused cell can have the wrong favicon.

[Olivier, 2017-03-28 13:14:13]

lgtm

[gambard, 2017-03-28 13:14:41]

The CQ bit was checked by gambard@chromium.org

[commit-bot: I haz the power, 2017-03-28 13:15:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 13:24:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 13:24:26]

Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[gambard, 2017-03-28 15:15:23]

The CQ bit was checked by gambard@chromium.org

[gambard, 2017-03-28 15:15:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
olivierrobin@chromium.org
Link to the patchset: https://codereview.chromium.org/2783433004/#ps40001
(title: "Fix tests")

[commit-bot: I haz the power, 2017-03-28 15:16:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 16:01:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 16:01:57]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[gambard, 2017-03-29 06:56:53]

The CQ bit was checked by gambard@chromium.org

[gambard, 2017-03-29 06:56:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
olivierrobin@chromium.org
Link to the patchset: https://codereview.chromium.org/2783433004/#ps60001
(title: "Fix tests")

[commit-bot: I haz the power, 2017-03-29 06:57:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gambard, 2017-03-29 07:29:26]

The CQ bit was unchecked by gambard@chromium.org

[gambard, 2017-03-29 07:29:31]

The CQ bit was checked by gambard@chromium.org

[commit-bot: I haz the power, 2017-03-29 07:29:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 07:55:57]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490772571856090,
"parent_rev": "36527589aedb56b1696c30f4b548b9d3a319fdfc", "commit_rev":
"28ea8191e57cf1a852a9e48f5298a3049687b006"}

[commit-bot: I haz the power, 2017-03-29 07:56:49]

Description was changed from

==========
Fetch Reading List favicon in the Controller

This CL fetches the favicon for the Reading List item in the ViewController
instead of in the item.

BUG=705881
==========

to

==========
Fetch Reading List favicon in the Controller

This CL fetches the favicon for the Reading List item in the ViewController
instead of in the item.

BUG=705881

Review-Url: https://codereview.chromium.org/2783433004
Cr-Commit-Position: refs/heads/master@{#460322}
Committed:
https://chromium.googlesource.com/chromium/src/+/28ea8191e57cf1a852a9e48f5298...
==========

[commit-bot: I haz the power, 2017-03-29 07:56:50]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/28ea8191e57cf1a852a9e48f5298...