Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.mm

Issue 2783433004: Fetch Reading List favicon in the Controller (Closed)
Patch Set: Fix tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.mm
diff --git a/ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.mm b/ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.mm
index 5f88f09ceb3950d932c059da2dd7c3dd9b54b527..12fdeae253557eb671b32c588aaf135475a759cd 100644
--- a/ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.mm
+++ b/ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.mm
@@ -52,11 +52,6 @@ const CGFloat kMargin = 16;
@interface ReadingListCollectionViewItem ()<ReadingListCellDelegate> {
GURL _url;
}
-// Attributes provider used to retrieve favicons.
-@property(nonatomic, strong)
- FaviconAttributesProvider* faviconAttributesProvider;
-// Attributes for favicon. Fetched in init, then retained for future updates.
-@property(nonatomic, strong) FaviconAttributes* attributes;
// The cell that is displaying this item, if any. Used to reload favicon when
// the cell is on screen. Backed by WeakNSObject.
@property(nonatomic, weak) ReadingListCell* displayedCell;
@@ -67,7 +62,6 @@ const CGFloat kMargin = 16;
@end
@implementation ReadingListCollectionViewItem
-@synthesize faviconAttributesProvider = _faviconAttributesProvider;
@synthesize attributes = _attributes;
@synthesize text = _text;
@synthesize detailText = _detailText;
@@ -78,39 +72,17 @@ const CGFloat kMargin = 16;
@synthesize accessibilityDelegate = _accessibilityDelegate;
- (instancetype)initWithType:(NSInteger)type
- attributesProvider:(FaviconAttributesProvider*)provider
url:(const GURL&)url
distillationState:(ReadingListEntry::DistillationState)state {
self = [super initWithType:type];
if (!self)
return nil;
self.cellClass = [ReadingListCell class];
- _faviconAttributesProvider = provider;
_url = url;
_distillationState = state;
return self;
}
-- (void)setFaviconPageURL:(GURL)url {
- _faviconPageURL = url;
- // |self| owns |provider|, |provider| owns the block, so a week self reference
- // is necessary.
- __weak ReadingListCollectionViewItem* weakSelf = self;
- [_faviconAttributesProvider
- fetchFaviconAttributesForURL:url
- completion:^(FaviconAttributes* _Nonnull attributes) {
- ReadingListCollectionViewItem* strongSelf = weakSelf;
- if (!strongSelf) {
- return;
- }
-
- strongSelf.attributes = attributes;
-
- [strongSelf.displayedCell.faviconView
- configureWithAttributes:strongSelf.attributes];
- }];
-}
-
#pragma mark - property
- (void)setDistillationState:

Powered by Google App Engine
This is Rietveld 408576698