Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2783393002: Revert of Assert sequence validity on non-thread-safe RefCount manipulations (2) (Closed)

Created:
3 years, 8 months ago by wjmaclean
Modified:
3 years, 8 months ago
CC:
chromium-reviews, gavinp+memory_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Assert sequence validity on non-thread-safe RefCount manipulations (2) (patchset #35 id:700001 of https://codereview.chromium.org/2666423002/ ) Reason for revert: Speculative revert to see if this CL is the cause of the RenderWidgetHostViewChildFrameTest.ForwardsBeginFrameAcks failures on https://uberchromegw.corp.google.com/i/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/22400 Original issue's description: > Assert sequence validity on non-thread-safe RefCount manipulations > > This CL adds DCHECKs to non-thread-safe base::RefCount to trace racy > ref count manipulations. A ref counted object is considered to be bound > to a sequence if the count is more than one. After this CL, ref count > manipulations to a sequenced-bound one cause DCHECK failure. > > This CL also adds ScopedAllowCrossThreadRefCountAccess to opt out, > and applies the opt-out as needed. > > BUG=688072 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2666423002 > Cr-Commit-Position: refs/heads/master@{#460773} > Committed: https://chromium.googlesource.com/chromium/src/+/f9a212dec0fec22e21d7f66ad1aa9414ed1dc068 TBR=gab@chromium.org,raymes@chromium.org,zmo@chromium.org,yzshen@chromium.org,danakj@chromium.org,tzik@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=688072 Review-Url: https://codereview.chromium.org/2783393002 Cr-Commit-Position: refs/heads/master@{#460859} Committed: https://chromium.googlesource.com/chromium/src/+/4d5b2df34c2023956579d96e89aaaacf04e510d1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -160 lines) Patch
M base/at_exit.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M base/memory/ref_counted.h View 6 chunks +1 line, -47 lines 0 comments Download
M base/memory/ref_counted.cc View 2 chunks +0 lines, -25 lines 0 comments Download
M cc/trees/proxy_impl.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.cc View 3 chunks +0 lines, -17 lines 0 comments Download
M gpu/command_buffer/service/mailbox_manager_sync.cc View 5 chunks +0 lines, -20 lines 0 comments Download
M ppapi/shared_impl/proxy_lock.h View 8 chunks +0 lines, -36 lines 0 comments Download
M ppapi/shared_impl/tracked_callback.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
wjmaclean
Created Revert of Assert sequence validity on non-thread-safe RefCount manipulations (2)
3 years, 8 months ago (2017-03-30 19:51:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783393002/1
3 years, 8 months ago (2017-03-30 19:52:44 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 19:59:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4d5b2df34c2023956579d96e89aa...

Powered by Google App Engine
This is Rietveld 408576698