Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: content/browser/gpu/gpu_data_manager_impl.cc

Issue 2783393002: Revert of Assert sequence validity on non-thread-safe RefCount manipulations (2) (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/proxy_impl.cc ('k') | gpu/command_buffer/service/mailbox_manager_sync.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/gpu/gpu_data_manager_impl.cc
diff --git a/content/browser/gpu/gpu_data_manager_impl.cc b/content/browser/gpu/gpu_data_manager_impl.cc
index 0d5202676762de99ed03af43cad758a6407fc045..0c74a29bdcf0d0025317a89c2863504a25a8c2e7 100644
--- a/content/browser/gpu/gpu_data_manager_impl.cc
+++ b/content/browser/gpu/gpu_data_manager_impl.cc
@@ -22,10 +22,6 @@
void GpuDataManagerImpl::InitializeForTesting(
const std::string& gpu_blacklist_json, const gpu::GPUInfo& gpu_info) {
base::AutoLock auto_lock(lock_);
- // Relax the cross-thread access restriction to non-thread-safe RefCount.
- // See the comment in Initialize().
- base::ScopedAllowCrossThreadRefCountAccess
- allow_cross_thread_ref_count_access;
private_->InitializeForTesting(gpu_blacklist_json, gpu_info);
}
@@ -150,20 +146,11 @@
void GpuDataManagerImpl::Initialize() {
base::AutoLock auto_lock(lock_);
- // Relax the cross-thread access restriction to non-thread-safe RefCount.
- // GpuDataManagerImplPrivate has GpuControlLists, which touches
- // non-thread-safe GpuControlListEntry RefCount in the lock.
- base::ScopedAllowCrossThreadRefCountAccess
- allow_cross_thread_ref_count_access;
private_->Initialize();
}
void GpuDataManagerImpl::UpdateGpuInfo(const gpu::GPUInfo& gpu_info) {
base::AutoLock auto_lock(lock_);
- // Relax the cross-thread access restriction to non-thread-safe RefCount.
- // See the comment in Initialize().
- base::ScopedAllowCrossThreadRefCountAccess
- allow_cross_thread_ref_count_access;
private_->UpdateGpuInfo(gpu_info);
}
@@ -269,10 +256,6 @@
bool GpuDataManagerImpl::UpdateActiveGpu(uint32_t vendor_id,
uint32_t device_id) {
base::AutoLock auto_lock(lock_);
- // Relax the cross-thread access restriction to non-thread-safe RefCount.
- // See the comment in Initialize().
- base::ScopedAllowCrossThreadRefCountAccess
- allow_cross_thread_ref_count_access;
return private_->UpdateActiveGpu(vendor_id, device_id);
}
« no previous file with comments | « cc/trees/proxy_impl.cc ('k') | gpu/command_buffer/service/mailbox_manager_sync.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698