[Android,Cast] Report correctly when devices are not available.

[Android,Cast] Report correctly when devices are not available.

The ChromeMediaRouterDialogController now reports when the source URN is
not supported so that the native side can reject the PresentationRequest
correctly.
CastMediaRouteProvider now reports no sinks available if the source URN
is not supported or if Android MediaRouter's API are not present (like
on JB MR1). For the latter, we now do create ChromeMRP when MediaRouter
is null and check if it's null before using (was already checked
everywhere, except for one spot changed in this CL).

BUG=706882
TEST=manual at https://googlechrome.github.io/samples/presentation-api/

Review-Url: https://codereview.chromium.org/2783363002
Cr-Commit-Position: refs/heads/master@{#462887}
Committed: https://chromium.googlesource.com/chromium/src/+/8a9962171b6d2f8e98c9d312c433087425b3f154

[whywhat, 2017-03-30 19:04:46]

avayvod@chromium.org changed reviewers:
+ mlamouri@chromium.org

[whywhat, 2017-03-30 19:04:46]

PTaL

[whywhat, 2017-03-30 19:04:49]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 19:05:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 19:59:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 19:59:33]

Dry run: This issue passed the CQ dry run.

[mlamouri (slow - plz ping), 2017-03-30 21:30:13]

lgtm but could you add tests? :)

+zqzhang@ in case of he has ideas in how to test this.

[whywhat, 2017-04-06 23:35:42]

Rebased and added junit test

[whywhat, 2017-04-06 23:54:01]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 23:54:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 00:58:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 00:58:10]

Dry run: This issue passed the CQ dry run.

[mlamouri (slow - plz ping), 2017-04-07 11:20:20]

still lgtm with tests comments taken into account

https://codereview.chromium.org/2783363002/diff/20001/chrome/android/junit/sr...
File
chrome/android/junit/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProviderTest.java
(right):

https://codereview.chromium.org/2783363002/diff/20001/chrome/android/junit/sr...
chrome/android/junit/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProviderTest.java:33:
"https://google.com/cast/#__castAppId__=EF1A139F";
Is the ID a random value? If yes, what about making it clear by using sometihng
like DEADBEEF?

https://codereview.chromium.org/2783363002/diff/20001/chrome/android/junit/sr...
chrome/android/junit/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProviderTest.java:35:
"https://googlechrome.github.io/samples/presentation-api/receiver/index.html";
ditto, use https://example.com?

[whywhat, 2017-04-07 15:17:16]

Fixed the test URLs

[whywhat, 2017-04-07 15:23:42]

The CQ bit was checked by avayvod@chromium.org

[whywhat, 2017-04-07 15:23:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/2783363002/#ps40001
(title: "Fixed the test URLs")

[commit-bot: I haz the power, 2017-04-07 15:23:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 16:27:54]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491578622981020,
"parent_rev": "d6dbbe9a3f1a62bc6ec0414bd4bbd5d4c2d9f833", "commit_rev":
"8a9962171b6d2f8e98c9d312c433087425b3f154"}

[commit-bot: I haz the power, 2017-04-07 16:28:46]

Description was changed from

==========
[Android,Cast] Report correctly when devices are not available.

The ChromeMediaRouterDialogController now reports when the source URN is
not supported so that the native side can reject the PresentationRequest
correctly.
CastMediaRouteProvider now reports no sinks available if the source URN
is not supported or if Android MediaRouter's API are not present (like
on JB MR1). For the latter, we now do create ChromeMRP when MediaRouter
is null and check if it's null before using (was already checked
everywhere, except for one spot changed in this CL).

BUG=706882
TEST=manual at https://googlechrome.github.io/samples/presentation-api/
==========

to

==========
[Android,Cast] Report correctly when devices are not available.

The ChromeMediaRouterDialogController now reports when the source URN is
not supported so that the native side can reject the PresentationRequest
correctly.
CastMediaRouteProvider now reports no sinks available if the source URN
is not supported or if Android MediaRouter's API are not present (like
on JB MR1). For the latter, we now do create ChromeMRP when MediaRouter
is null and check if it's null before using (was already checked
everywhere, except for one spot changed in this CL).

BUG=706882
TEST=manual at https://googlechrome.github.io/samples/presentation-api/

Review-Url: https://codereview.chromium.org/2783363002
Cr-Commit-Position: refs/heads/master@{#462887}
Committed:
https://chromium.googlesource.com/chromium/src/+/8a9962171b6d2f8e98c9d312c433...
==========

[commit-bot: I haz the power, 2017-04-07 16:28:47]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8a9962171b6d2f8e98c9d312c433...