chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouterDialogController.java - Issue 2783363002: [Android,Cast] Report correctly when devices are not available.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouterDialogController.java

Issue 2783363002: [Android,Cast] Report correctly when devices are not available. (Closed)

Patch Set: Fixed the test URLs Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouter.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouterDialogController.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouterDialogController.java b/chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouterDialogController.java

index 7217bb8b590967c25620f9bddaa37ee1f6bb2a47..e895de9ad1c4890a8650a721626ca9878ad78f9f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouterDialogController.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouterDialogController.java

@@ -44,7 +44,10 @@ public class ChromeMediaRouterDialogController implements MediaRouteDialogDelega

if (isShowingDialog()) return;

MediaSource source = MediaSource.from(sourceUrn);

- if (source == null) return;

+ if (source == null) {

+ nativeOnMediaSourceNotSupported(mNativeDialogController);

+ return;

+ }

mDialogManager = new MediaRouteChooserDialogManager(source, this);

mDialogManager.openDialog();

@@ -60,7 +63,10 @@ public class ChromeMediaRouterDialogController implements MediaRouteDialogDelega

if (isShowingDialog()) return;

MediaSource source = MediaSource.from(sourceUrn);

- if (source == null) return;

+ if (source == null) {

+ nativeOnMediaSourceNotSupported(mNativeDialogController);

+ return;

+ }

mDialogManager = new MediaRouteControllerDialogManager(source, mediaRouteId, this);

mDialogManager.openDialog();

@@ -117,4 +123,5 @@ public class ChromeMediaRouterDialogController implements MediaRouteDialogDelega

native void nativeOnSinkSelected(

long nativeMediaRouterDialogControllerAndroid, String sinkId);

native void nativeOnRouteClosed(long nativeMediaRouterDialogControllerAndroid, String routeId);

+ native void nativeOnMediaSourceNotSupported(long nativeMediaRouterDialogControllerAndroid);

}