 Chromium Code Reviews
 Chromium Code Reviews Issue 2783343002:
  Remove URLRequestJobFactory::IsHandledURL.  (Closed)
    
  
    Issue 2783343002:
  Remove URLRequestJobFactory::IsHandledURL.  (Closed) 
  | Index: content/browser/download/download_manager_impl.cc | 
| diff --git a/content/browser/download/download_manager_impl.cc b/content/browser/download/download_manager_impl.cc | 
| index 83c279fc8e517e69c10ffb0f5fb15c8afca7f168..4f1aa6a49c4bf7a78cf797dab283d56dbe5bd413 100644 | 
| --- a/content/browser/download/download_manager_impl.cc | 
| +++ b/content/browser/download/download_manager_impl.cc | 
| @@ -564,7 +564,7 @@ DownloadInterruptReason DownloadManagerImpl::BeginDownloadRequest( | 
| } | 
| const net::URLRequestContext* request_context = url_request->context(); | 
| - if (!request_context->job_factory()->IsHandledURL(url)) { | 
| + if (!request_context->job_factory()->IsHandledProtocol(url.scheme())) { | 
| 
mmenke
2017/03/31 04:30:04
Blocking invalid URLs here seems reasonable (The a
 
asanka
2017/03/31 20:38:30
Acknowledged. It's also fine to let the request go
 | 
| DVLOG(1) << "Download request for unsupported protocol: " | 
| << url.possibly_invalid_spec(); | 
| return DOWNLOAD_INTERRUPT_REASON_NETWORK_INVALID_REQUEST; |