Remove URLRequestJobFactory::IsHandledURL.

content/browser/download/download_manager_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/download/download_manager_impl.h"
 
 #include <iterator>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 546 matching lines @@
 
   // Check if the renderer is permitted to request the requested URL.
   if (!ChildProcessSecurityPolicyImpl::GetInstance()->CanRequestURL(
           render_process_id, url)) {
     DVLOG(1) << "Denied unauthorized download request for "
              << url.possibly_invalid_spec();
     return DOWNLOAD_INTERRUPT_REASON_NETWORK_INVALID_REQUEST;
   }
 
   const net::URLRequestContext* request_context = url_request->context();
-  if (!request_context->job_factory()->IsHandledURL(url)) {
+  if (!request_context->job_factory()->IsHandledProtocol(url.scheme())) {

[mmenke, 2017/03/31 04:30:04]

Blocking invalid URLs here seems reasonable (The above check catches them
anyways)

[asanka, 2017/03/31 20:38:30]

Acknowledged. It's also fine to let the request go through and fail later. We
need to handle such cases anyway.

     DVLOG(1) << "Download request for unsupported protocol: "
              << url.possibly_invalid_spec();
     return DOWNLOAD_INTERRUPT_REASON_NETWORK_INVALID_REQUEST;
   }
 
   // From this point forward, the |DownloadResourceHandler| is responsible for
   // |started_callback|.
   // TODO(ananta)
   // Find a better way to create the DownloadResourceHandler instance.
   std::unique_ptr<ResourceHandler> handler(
@@ skipping 171 matching lines @@
   if (delegate_)
     delegate_->OpenDownload(download);
 }
 
 void DownloadManagerImpl::ShowDownloadInShell(DownloadItemImpl* download) {
   if (delegate_)
     delegate_->ShowDownloadInShell(download);
 }
 
 }  // namespace content