Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1964)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/download/save_file_manager.cc

Issue 2783343002: Remove URLRequestJobFactory::IsHandledURL. (Closed)
Patch Set: More fixes..... Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/download/download_manager_impl.cc ('K') | « content/browser/download/download_manager_impl.cc ('k') | content/browser/fileapi/file_system_dir_url_request_job_unittest.cc » ('j') | content/browser/loader/navigation_resource_throttle.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/save_file_manager.cc
diff --git a/content/browser/download/save_file_manager.cc b/content/browser/download/save_file_manager.cc
index 9d57d2ed1741c63e921b1616aebacb2033753384..256ef2811375b0a4eaffbd3518fda580fdf0e5b7 100644
--- a/content/browser/download/save_file_manager.cc
+++ b/content/browser/download/save_file_manager.cc
@@ -299,7 +299,7 @@ void SaveFileManager::OnSaveURL(const GURL& url,
DCHECK_CURRENTLY_ON(BrowserThread::IO);
const net::URLRequestContext* request_context = context->GetRequestContext();
- if (!request_context->job_factory()->IsHandledURL(url)) {
+ if (!request_context->job_factory()->IsHandledProtocol(url.scheme())) {
mmenke 2017/03/31 04:30:04 There's a DCHECK about URL validity before calling
asanka 2017/03/31 20:38:30 Acknowledged.
// Since any URLs which have non-standard scheme have been filtered
// by save manager(see GURL::SchemeIsStandard). This situation
// should not happen.
« content/browser/download/download_manager_impl.cc ('K') | « content/browser/download/download_manager_impl.cc ('k') | content/browser/fileapi/file_system_dir_url_request_job_unittest.cc » ('j') | content/browser/loader/navigation_resource_throttle.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698