Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 2783223004: Adds lots of Mojo documentation (Closed)

Created:
3 years, 8 months ago by Ken Rockot(use gerrit already)
Modified:
3 years, 8 months ago
Reviewers:
jam
CC:
Aaron Boodman, abarth-chromium, agrieve+watch_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds lots of Mojo documentation Adds documentation for Mojo IPC conversion and Mojo public system libraries for C and C++. Also updates Service Manager and client library documentation. BUG= TBR=yzshen@chromium.org,ben@chromium.org Review-Url: https://codereview.chromium.org/2783223004 Cr-Commit-Position: refs/heads/master@{#461306} Committed: https://chromium.googlesource.com/chromium/src/+/f59d2d6a9991788922660cd731754d81545edc7a

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4765 lines, -1049 lines) Patch
A ipc/README.md View 1 chunk +664 lines, -0 lines 1 comment Download
M mojo/README.md View 1 chunk +140 lines, -5 lines 0 comments Download
M mojo/edk/embedder/README.md View 3 chunks +24 lines, -5 lines 0 comments Download
M mojo/edk/system/dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
D mojo/public/README.md View 1 chunk +0 lines, -43 lines 0 comments Download
D mojo/public/c/README.md View 1 chunk +0 lines, -22 lines 0 comments Download
A mojo/public/c/system/README.md View 1 chunk +869 lines, -0 lines 0 comments Download
M mojo/public/c/system/buffer.h View 7 chunks +33 lines, -40 lines 0 comments Download
M mojo/public/c/system/data_pipe.h View 10 chunks +56 lines, -80 lines 0 comments Download
M mojo/public/c/system/platform_handle.h View 5 chunks +25 lines, -18 lines 0 comments Download
M mojo/public/c/system/types.h View 2 chunks +0 lines, -5 lines 0 comments Download
D mojo/public/cpp/README.md View 1 chunk +0 lines, -38 lines 0 comments Download
A mojo/public/cpp/bindings/README.md View 1 chunk +1231 lines, -0 lines 0 comments Download
A mojo/public/cpp/system/README.md View 1 chunk +396 lines, -0 lines 0 comments Download
A mojo/public/java/bindings/README.md View 1 chunk +12 lines, -0 lines 0 comments Download
A mojo/public/java/system/README.md View 1 chunk +25 lines, -0 lines 0 comments Download
A mojo/public/js/README.md View 1 chunk +7 lines, -0 lines 0 comments Download
A mojo/public/tools/bindings/README.md View 1 chunk +749 lines, -0 lines 0 comments Download
M services/README.md View 2 chunks +32 lines, -23 lines 0 comments Download
M services/service_manager/README.md View 2 chunks +502 lines, -769 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Ken Rockot(use gerrit already)
Gonna land this to replace the vast majority of our Sites page docs. A lot ...
3 years, 8 months ago (2017-03-31 23:18:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783223004/1
3 years, 8 months ago (2017-03-31 23:19:24 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/262817)
3 years, 8 months ago (2017-04-01 01:43:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783223004/1
3 years, 8 months ago (2017-04-01 02:02:49 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f59d2d6a9991788922660cd731754d81545edc7a
3 years, 8 months ago (2017-04-01 02:50:04 UTC) #11
jam
3 years, 8 months ago (2017-04-04 16:05:55 UTC) #13
Message was sent while issue was closed.
https://codereview.chromium.org/2783223004/diff/1/ipc/README.md
File ipc/README.md (right):

https://codereview.chromium.org/2783223004/diff/1/ipc/README.md#newcode55
ipc/README.md:55: conversions.
services/ for the foreseeable future is where foundational services are going,
so I don't think we want to make this statement yet. i.e. there could still be
many one-off IPCs for browser features or web platform features, and these would
be in chrome/ or blink/.

Perhaps this can be worded as: code which is part of foundational services (more
info at https://www.chromium.org/servicification) belongs in services/. For
other code, mojoms generally go where the old messages files went.

Powered by Google App Engine
This is Rietveld 408576698