Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

Issue 2783203002: [wrapper-tracing] Emite write barrier upon associating a wrapper (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 13 matching lines...) Expand all
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef ScriptWrappable_h 31 #ifndef ScriptWrappable_h
32 #define ScriptWrappable_h 32 #define ScriptWrappable_h
33 33
34 #include "bindings/core/v8/ScriptWrappableVisitor.h"
34 #include "bindings/core/v8/WrapperTypeInfo.h" 35 #include "bindings/core/v8/WrapperTypeInfo.h"
35 #include "core/CoreExport.h" 36 #include "core/CoreExport.h"
36 #include "platform/heap/Handle.h" 37 #include "platform/heap/Handle.h"
37 #include "wtf/Compiler.h" 38 #include "wtf/Compiler.h"
38 #include "wtf/Noncopyable.h" 39 #include "wtf/Noncopyable.h"
39 #include "wtf/TypeTraits.h" 40 #include "wtf/TypeTraits.h"
40 #include <v8.h> 41 #include <v8.h>
41 42
42 namespace blink { 43 namespace blink {
43 44
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 v8::Local<v8::Object>& wrapper) { 116 v8::Local<v8::Object>& wrapper) {
116 ASSERT(!wrapper.IsEmpty()); 117 ASSERT(!wrapper.IsEmpty());
117 if (UNLIKELY(containsWrapper())) { 118 if (UNLIKELY(containsWrapper())) {
118 wrapper = mainWorldWrapper(isolate); 119 wrapper = mainWorldWrapper(isolate);
119 return false; 120 return false;
120 } 121 }
121 m_mainWorldWrapper.Reset(isolate, wrapper); 122 m_mainWorldWrapper.Reset(isolate, wrapper);
122 wrapperTypeInfo->configureWrapper(&m_mainWorldWrapper); 123 wrapperTypeInfo->configureWrapper(&m_mainWorldWrapper);
123 m_mainWorldWrapper.SetWeak(); 124 m_mainWorldWrapper.SetWeak();
124 ASSERT(containsWrapper()); 125 ASSERT(containsWrapper());
126 ScriptWrappableVisitor::writeBarrier(&m_mainWorldWrapper);
125 return true; 127 return true;
126 } 128 }
127 129
128 bool isEqualTo(const v8::Local<v8::Object>& other) const { 130 bool isEqualTo(const v8::Local<v8::Object>& other) const {
129 return m_mainWorldWrapper == other; 131 return m_mainWorldWrapper == other;
130 } 132 }
131 133
132 // Provides a way to convert Node* to ScriptWrappable* without including 134 // Provides a way to convert Node* to ScriptWrappable* without including
133 // "core/dom/Node.h". 135 // "core/dom/Node.h".
134 // 136 //
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 #define DECLARE_WRAPPERTYPEINFO() \ 208 #define DECLARE_WRAPPERTYPEINFO() \
207 public: \ 209 public: \
208 const WrapperTypeInfo* wrapperTypeInfo() const override; \ 210 const WrapperTypeInfo* wrapperTypeInfo() const override; \
209 \ 211 \
210 private: \ 212 private: \
211 typedef void end_of_define_wrappertypeinfo_not_reached_t 213 typedef void end_of_define_wrappertypeinfo_not_reached_t
212 214
213 } // namespace blink 215 } // namespace blink
214 216
215 #endif // ScriptWrappable_h 217 #endif // ScriptWrappable_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698