Issue 2771413009: [inspector] get rid of ConsoleHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2771413009: [inspector] get rid of ConsoleHelper (Closed)

Created:
3 years, 8 months ago by kozy

Modified:
3 years, 8 months ago

Reviewers:
dgozman

CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org

Target Ref:
refs/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[inspector] get rid of ConsoleHelper Since all implementation methods are member of V8Console we can move everything there. BUG=v8:6175 R=dgozman@chromium.org

Patch Set 1 #

Patch Set 2 : dont use info.GetIsolate() #

Patch Set 3 : a #

Patch Set 4 : rebased #

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+285 lines, -251 lines)			Patch
	M	src/inspector/v8-console.h	View	1 2 3	3 chunks	+34 lines, -0 lines	0 comments	Download
	M	src/inspector/v8-console.cc	View	1 2 3	10 chunks	+251 lines, -251 lines	0 comments	Download

Depends on Patchset:

Issue 2783073002 Patch 40001

Dependent Patchsets:

Issue 2785293002 Patch 20001

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kozy

Dmitry, please take a look. It depends on https://codereview.chromium.org/2783073002/

3 years, 8 months ago (2017-03-30 02:31:20 UTC) #1

dgozman

The code looks good, but let's measure the performance beforehand.

3 years, 8 months ago (2017-03-30 21:29:49 UTC) #2

kozy

3 years, 8 months ago (2017-03-31 00:58:08 UTC) #4

Message was sent while issue was closed.

This CL actually forces disabled caching of contextId, so I think we should left
ConsoleHelper as is, please take a look on next CL:
https://codereview.chromium.org/2785293002/

Before ConsoleHelper and after ConsoleHelper show performace regression of this
CL:
http://imgur.com/a/t0nr3

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages