Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Issue 2783033002: Treat should().throw(undefined) like should().throw() (Closed)

Created:
3 years, 8 months ago by Raymond Toy
Modified:
3 years, 8 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Treat should().throw(undefined) like should().throw() Interpret throw(undefined) to mean that an error of any type is expected. This is the same as throw(). BUG=706558 TEST=audit.html Review-Url: https://codereview.chromium.org/2783033002 Cr-Commit-Position: refs/heads/master@{#460584} Committed: https://chromium.googlesource.com/chromium/src/+/6ff2dbc1c7424cd12b6ac35ec438eb3057dc65d8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/resources/audit.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/unit-tests/audit.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-expected.txt View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Raymond Toy
PTAL. I think this is what we want. The old Should.throw() did this.
3 years, 8 months ago (2017-03-29 21:26:48 UTC) #2
hongchan
lgtm
3 years, 8 months ago (2017-03-29 21:56:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783033002/1
3 years, 8 months ago (2017-03-29 22:01:29 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 23:58:26 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6ff2dbc1c7424cd12b6ac35ec438...

Powered by Google App Engine
This is Rietveld 408576698