third_party/WebKit/LayoutTests/webaudio/resources/audit.js - Issue 2783033002: Treat should().throw(undefined) like should().throw()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/webaudio/resources/audit.js

Issue 2783033002: Treat should().throw(undefined) like should().throw() (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/LayoutTests/webaudio/resources/audit.js

diff --git a/third_party/WebKit/LayoutTests/webaudio/resources/audit.js b/third_party/WebKit/LayoutTests/webaudio/resources/audit.js

index 80fe9cdbea422a7fb76eb56d2c15c0beac811a46..d2946161efbb1f2cd2f707a8d6487db5145ddee8 100644

--- a/third_party/WebKit/LayoutTests/webaudio/resources/audit.js

+++ b/third_party/WebKit/LayoutTests/webaudio/resources/audit.js

@@ -287,7 +287,7 @@ window.Audit = (function () {

// Catch did not happen, so the test is failed.

failDetail = '${actual} did not throw an exception.';

} catch (error) {

- if (this._expected === null) {

+ if (this._expected === null || this._expected === undefined) {

// The expected error type was not given.

didThrowCorrectly = true;

passDetail = '${actual} threw ' + error.name + ': "'

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/webaudio/unit-tests/audit.html » ('j') | no next file with comments »