Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2782893003: [inspector] fixed crash in InternalPromiseHasUserDefinedRejectHandler (Closed)

Created:
3 years, 8 months ago by kozy
Modified:
3 years, 8 months ago
Reviewers:
gsathya
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] fixed crash in InternalPromiseHasUserDefinedRejectHandler Method should be ready to symbols inside of queue_arr. BUG=v8:6168 R=gsathya@chromium.org Review-Url: https://codereview.chromium.org/2782893003 Cr-Commit-Position: refs/heads/master@{#44254} Committed: https://chromium.googlesource.com/v8/v8/+/29dc4898c84bf5b8be284df069b01ecb95dd2f8e

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M src/isolate.cc View 1 chunk +10 lines, -3 lines 0 comments Download
M test/inspector/inspector.status View 1 chunk +0 lines, -4 lines 1 comment Download

Messages

Total messages: 12 (5 generated)
kozy
Sathya, please take a look.
3 years, 8 months ago (2017-03-29 21:01:12 UTC) #1
gsathya
On 2017/03/29 21:01:12, kozy wrote: > Sathya, please take a look. looks like there's a ...
3 years, 8 months ago (2017-03-29 21:04:48 UTC) #3
gsathya
https://codereview.chromium.org/2782893003/diff/1/test/inspector/inspector.status File test/inspector/inspector.status (left): https://codereview.chromium.org/2782893003/diff/1/test/inspector/inspector.status#oldcode8 test/inspector/inspector.status:8: 'runtime/await-promise': [SKIP], do you know why this didn't fail ...
3 years, 8 months ago (2017-03-29 21:04:54 UTC) #4
kozy
On 2017/03/29 21:04:54, gsathya wrote: > https://codereview.chromium.org/2782893003/diff/1/test/inspector/inspector.status > File test/inspector/inspector.status (left): > > https://codereview.chromium.org/2782893003/diff/1/test/inspector/inspector.status#oldcode8 > ...
3 years, 8 months ago (2017-03-29 21:10:07 UTC) #6
gsathya
On 2017/03/29 21:10:07, kozy wrote: > On 2017/03/29 21:04:54, gsathya wrote: > > > https://codereview.chromium.org/2782893003/diff/1/test/inspector/inspector.status ...
3 years, 8 months ago (2017-03-29 21:11:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782893003/1
3 years, 8 months ago (2017-03-29 21:12:03 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 22:21:48 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/29dc4898c84bf5b8be284df069b01ecb95d...

Powered by Google App Engine
This is Rietveld 408576698