Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2777413005: [inspector] correctly test more variants. (Closed)

Created:
3 years, 8 months ago by Yang
Modified:
3 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org, kozy
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] correctly test more variants. This flushed out a number of bugs. To reproduce, remove the inspector.status file entries, build with GN, and run `tools/run-tests.py --gn --exhaustive-variants inspector`. R=mstarzinger@chromium.org BUG=v8:6165, v8:6166, v8:6167, v8:6168, v8:6170, v8:6171 Review-Url: https://codereview.chromium.org/2777413005 Cr-Commit-Position: refs/heads/master@{#44242} Committed: https://chromium.googlesource.com/v8/v8/+/891bbe2c858d9047b225ebbb4f89c56aff90574d

Patch Set 1 #

Patch Set 2 : [inspector] correctly test more variants. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -3 lines) Patch
M test/inspector/inspector.status View 1 1 chunk +24 lines, -0 lines 0 comments Download
M test/inspector/inspector-test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/inspector/testcfg.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Yang
Please take a look!
3 years, 8 months ago (2017-03-29 13:13:39 UTC) #1
Michael Starzinger
LGTM. Thanks!
3 years, 8 months ago (2017-03-29 14:02:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777413005/20001
3 years, 8 months ago (2017-03-29 18:06:44 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 18:09:01 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/891bbe2c858d9047b225ebbb4f89c56aff9...

Powered by Google App Engine
This is Rietveld 408576698