[ios] Remove CWV_IMPLEMENTATION hack in ChromeWebView implementation.

[ios] Remove CWV_IMPLEMENTATION hack in ChromeWebView implementation.

BUG=704946

[sdefresne, 2017-03-29 15:55:45]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 15:56:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-03-29 15:57:42]

sdefresne@chromium.org changed reviewers:
+ michaeldo@chromium.org

[sdefresne, 2017-03-29 15:57:43]

Please take a look.

Note that I had to remove ios/web_view/internal/* targets as the creation of a
framework requires creating a header map to have both path in the framework and
out of the framework working, and it was easier to do as a single target
(without completely refactoring the ios_framework_bundle template).

[commit-bot: I haz the power, 2017-03-29 16:54:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 16:54:20]

Dry run: This issue passed the CQ dry run.

[michaeldo, 2017-03-29 17:23:08]

On 2017/03/29 15:57:43, sdefresne wrote:
> Please take a look.
> 
> Note that I had to remove ios/web_view/internal/* targets as the creation of a
> framework requires creating a header map to have both path in the framework
and
> out of the framework working, and it was easier to do as a single target
> (without completely refactoring the ios_framework_bundle template).

It looks like there is a rebase in this CL so the patch is a little hard to read
through, but I'm not sure why the additional changes are needed. I was working
on something similar, and it looks like the following CL works. Am I missing
something that requires the gn change?

https://codereview.chromium.org/2782253002

[sdefresne, 2017-03-29 18:05:25]

There is no rebase, just some additional cleanup (sorting headers, ...). If your
CL works, then I think it is better to land yours.

[sdefresne, 2017-03-29 18:19:18]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 18:20:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 18:25:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 18:25:07]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[michaeldo, 2017-03-29 20:20:40]

On 2017/03/29 18:05:25, sdefresne wrote:
> There is no rebase, just some additional cleanup (sorting headers, ...). If
your
> CL works, then I think it is better to land yours.

I see, sorry it's not a rebase, but it is including the changes from the
following CL instead of being dependent on it, which threw me off of the exact
change here.

https://codereview.chromium.org/2772503006

[sdefresne, 2017-03-30 09:44:50]

Description was changed from

==========
[ios] Remove CWV_IMPLEMENTATION hack in ChromeWebView implementation.

BUG=704946
==========

to

==========
[ios] Remove CWV_IMPLEMENTATION hack in ChromeWebView implementation.

BUG=704946
==========

[sdefresne, 2017-03-30 09:45:06]

Obsolete. Closing. Thank you michaeldo for you CL.