Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ios/web_view/shell/BUILD.gn

Issue 2782823004: [ios] Remove CWV_IMPLEMENTATION hack in ChromeWebView implementation. (Closed)
Patch Set: Mark all files as private for gn. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web_view/public/cwv_web_view_configuration.h ('k') | ios/web_view/shell/shell_app_delegate.m » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web_view/shell/BUILD.gn
diff --git a/ios/web_view/shell/BUILD.gn b/ios/web_view/shell/BUILD.gn
index 4e08849fab07ba026a842b01249caff68a7c763e..790681efeb1a712399ad6336a777774e058a18c5 100644
--- a/ios/web_view/shell/BUILD.gn
+++ b/ios/web_view/shell/BUILD.gn
@@ -30,18 +30,9 @@ source_set("shell") {
"translate_controller.m",
]
- # A workaround for an issue that we need to use the form:
- # #include "ios/web_view/public/cwv_export.h"
- # instead of:
- # #include <ChromeWebView/cwv_export.h>
- # when building this app.
- #
- # TODO(crbug.com/704946): Solve the issue and remove this workaround.
- defines = [ "CWV_IMPLEMENTATION" ]
-
deps = [
":resources",
- "//ios/web_view",
+ "//ios/web_view:web_view+link",
]
libs = [
« no previous file with comments | « ios/web_view/public/cwv_web_view_configuration.h ('k') | ios/web_view/shell/shell_app_delegate.m » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698