Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 2772503006: Use framework includes in ios/web_view/shell. (Closed)

Created:
3 years, 9 months ago by michaeldo
Modified:
3 years, 8 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use framework includes in ios/web_view/shell. BUG=704946 Review-Url: https://codereview.chromium.org/2772503006 Cr-Commit-Position: refs/heads/master@{#460424} Committed: https://chromium.googlesource.com/chromium/src/+/05eae9e2267ccd7d3cf5387339e34badb1e0a88e

Patch Set 1 #

Patch Set 2 : Link against framework. #

Total comments: 1

Patch Set 3 : Rebase #

Patch Set 4 : Remove workaround for header includes. #

Patch Set 5 : Update copyright year. #

Patch Set 6 : Rebase #

Patch Set 7 : Fix framework header includes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -20 lines) Patch
M ios/web_view/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
A ios/web_view/public/ChromeWebView.h View 1 2 3 4 5 6 1 chunk +19 lines, -0 lines 0 comments Download
M ios/web_view/shell/BUILD.gn View 1 2 3 2 chunks +1 line, -12 lines 0 comments Download
M ios/web_view/shell/shell_app_delegate.m View 1 chunk +2 lines, -1 line 0 comments Download
M ios/web_view/shell/shell_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web_view/shell/shell_view_controller.m View 1 chunk +1 line, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 24 (13 generated)
michaeldo
3 years, 9 months ago (2017-03-28 00:03:45 UTC) #2
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/2772503006/diff/20001/ios/web_view/public/ChromeWebView.h File ios/web_view/public/ChromeWebView.h (right): https://codereview.chromium.org/2772503006/diff/20001/ios/web_view/public/ChromeWebView.h#newcode1 ios/web_view/public/ChromeWebView.h:1: // Copyright 2014 The Chromium Authors. All rights ...
3 years, 8 months ago (2017-03-28 01:48:17 UTC) #3
Hiroshi Ichikawa
Can you also rebase and remove the workaround I have just added: https://codereview.chromium.org/2770633002/diff/140001/ios/web_view/shell/BUILD.gn which should ...
3 years, 8 months ago (2017-03-28 05:41:51 UTC) #4
michaeldo
On 2017/03/28 05:41:51, Hiroshi Ichikawa wrote: > Can you also rebase and remove the workaround ...
3 years, 8 months ago (2017-03-28 18:22:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772503006/80001
3 years, 8 months ago (2017-03-28 18:22:56 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/337554) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 8 months ago (2017-03-28 18:30:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772503006/80001
3 years, 8 months ago (2017-03-29 06:47:38 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/393647)
3 years, 8 months ago (2017-03-29 06:52:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772503006/100001
3 years, 8 months ago (2017-03-29 14:45:50 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772503006/120001
3 years, 8 months ago (2017-03-29 15:50:03 UTC) #21
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 16:49:41 UTC) #24
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/05eae9e2267ccd7d3cf5387339e3...

Powered by Google App Engine
This is Rietveld 408576698