Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2782803002: Move tracked prefs into services/preferences/tracked. (Closed)

Created:
3 years, 8 months ago by Sam McNally
Modified:
3 years, 8 months ago
CC:
chromium-reviews, vakh+watch_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, grt+watch_chromium.org, sdefresne+watchlist_chromium.org, timvolodine, abarth-chromium, Aaron Boodman, yzshen+watch_chromium.org, blundell+watchlist_chromium.org, darin (slow to review), mac-reviews_chromium.org, qsr+mojo_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move tracked prefs into services/preferences/tracked. BUG=654988 TBR=agl@chromium.org Review-Url: https://codereview.chromium.org/2782803002 Cr-Commit-Position: refs/heads/master@{#461359} Committed: https://chromium.googlesource.com/chromium/src/+/fb473a87fb9a0cb77a70811505929ba08c580e74

Patch Set 1 : #

Total comments: 26

Patch Set 2 : #

Total comments: 6

Patch Set 3 : rebase #

Patch Set 4 : #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+801 lines, -7736 lines) Patch
M chrome/browser/BUILD.gn View 1 2 3 4 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/prefs/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/prefs/chrome_pref_service_factory.cc View 4 chunks +19 lines, -14 lines 0 comments Download
M chrome/browser/prefs/profile_pref_store_manager.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/prefs/profile_pref_store_manager.cc View 1 2 3 4 3 chunks +19 lines, -18 lines 0 comments Download
M chrome/browser/prefs/profile_pref_store_manager_unittest.cc View 1 2 3 4 14 chunks +51 lines, -52 lines 0 comments Download
M chrome/browser/prefs/tracked/pref_hash_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.h View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc View 4 chunks +15 lines, -13 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc View 10 chunks +47 lines, -55 lines 0 comments Download
M components/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D components/user_prefs/tracked/BUILD.gn View 1 chunk +0 lines, -95 lines 0 comments Download
D components/user_prefs/tracked/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D components/user_prefs/tracked/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D components/user_prefs/tracked/device_id.h View 1 chunk +0 lines, -23 lines 0 comments Download
D components/user_prefs/tracked/device_id_mac.cc View 1 chunk +0 lines, -32 lines 0 comments Download
D components/user_prefs/tracked/device_id_stub.cc View 1 chunk +0 lines, -11 lines 0 comments Download
D components/user_prefs/tracked/device_id_unittest.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D components/user_prefs/tracked/device_id_win.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D components/user_prefs/tracked/dictionary_hash_store_contents.h View 1 chunk +0 lines, -62 lines 0 comments Download
D components/user_prefs/tracked/dictionary_hash_store_contents.cc View 1 chunk +0 lines, -134 lines 0 comments Download
D components/user_prefs/tracked/hash_store_contents.h View 1 chunk +0 lines, -90 lines 0 comments Download
D components/user_prefs/tracked/interceptable_pref_filter.h View 1 chunk +0 lines, -68 lines 0 comments Download
D components/user_prefs/tracked/interceptable_pref_filter.cc View 1 chunk +0 lines, -41 lines 0 comments Download
D components/user_prefs/tracked/mock_validation_delegate.h View 1 chunk +0 lines, -116 lines 0 comments Download
D components/user_prefs/tracked/mock_validation_delegate.cc View 1 chunk +0 lines, -79 lines 0 comments Download
D components/user_prefs/tracked/pref_hash_calculator.h View 1 chunk +0 lines, -55 lines 0 comments Download
D components/user_prefs/tracked/pref_hash_calculator.cc View 1 chunk +0 lines, -113 lines 0 comments Download
D components/user_prefs/tracked/pref_hash_calculator_unittest.cc View 1 chunk +0 lines, -196 lines 0 comments Download
D components/user_prefs/tracked/pref_hash_filter.h View 1 chunk +0 lines, -181 lines 0 comments Download
D components/user_prefs/tracked/pref_hash_filter.cc View 1 chunk +0 lines, -371 lines 0 comments Download
D components/user_prefs/tracked/pref_hash_filter_unittest.cc View 1 chunk +0 lines, -1367 lines 0 comments Download
D components/user_prefs/tracked/pref_hash_store.h View 1 chunk +0 lines, -48 lines 0 comments Download
D components/user_prefs/tracked/pref_hash_store_impl.h View 1 chunk +0 lines, -61 lines 0 comments Download
D components/user_prefs/tracked/pref_hash_store_impl.cc View 1 chunk +0 lines, -319 lines 0 comments Download
D components/user_prefs/tracked/pref_hash_store_impl_unittest.cc View 1 chunk +0 lines, -518 lines 0 comments Download
D components/user_prefs/tracked/pref_hash_store_transaction.h View 1 chunk +0 lines, -102 lines 0 comments Download
D components/user_prefs/tracked/pref_names.h View 1 chunk +0 lines, -14 lines 0 comments Download
D components/user_prefs/tracked/pref_names.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D components/user_prefs/tracked/registry_hash_store_contents_win.h View 1 chunk +0 lines, -49 lines 0 comments Download
D components/user_prefs/tracked/registry_hash_store_contents_win.cc View 1 chunk +0 lines, -182 lines 0 comments Download
D components/user_prefs/tracked/registry_hash_store_contents_win_unittest.cc View 1 chunk +0 lines, -120 lines 0 comments Download
D components/user_prefs/tracked/segregated_pref_store.h View 1 chunk +0 lines, -115 lines 0 comments Download
D components/user_prefs/tracked/segregated_pref_store.cc View 1 chunk +0 lines, -194 lines 0 comments Download
D components/user_prefs/tracked/segregated_pref_store_unittest.cc View 1 chunk +0 lines, -305 lines 0 comments Download
D components/user_prefs/tracked/tracked_atomic_preference.h View 1 chunk +0 lines, -54 lines 0 comments Download
D components/user_prefs/tracked/tracked_atomic_preference.cc View 1 chunk +0 lines, -90 lines 0 comments Download
D components/user_prefs/tracked/tracked_preference.h View 1 chunk +0 lines, -44 lines 0 comments Download
D components/user_prefs/tracked/tracked_preference_helper.h View 1 chunk +0 lines, -70 lines 0 comments Download
D components/user_prefs/tracked/tracked_preference_helper.cc View 1 2 3 4 1 chunk +0 lines, -136 lines 0 comments Download
D components/user_prefs/tracked/tracked_preference_histogram_names.h View 1 chunk +0 lines, -26 lines 0 comments Download
D components/user_prefs/tracked/tracked_preference_histogram_names.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D components/user_prefs/tracked/tracked_preferences_migration.h View 1 chunk +0 lines, -45 lines 0 comments Download
D components/user_prefs/tracked/tracked_preferences_migration.cc View 1 chunk +0 lines, -342 lines 0 comments Download
D components/user_prefs/tracked/tracked_preferences_migration_unittest.cc View 1 chunk +0 lines, -655 lines 0 comments Download
D components/user_prefs/tracked/tracked_split_preference.h View 1 chunk +0 lines, -57 lines 0 comments Download
D components/user_prefs/tracked/tracked_split_preference.cc View 1 chunk +0 lines, -120 lines 0 comments Download
M services/preferences/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M services/preferences/public/cpp/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
A services/preferences/public/cpp/tracked/BUILD.gn View 1 2 3 1 chunk +33 lines, -0 lines 0 comments Download
A + services/preferences/public/cpp/tracked/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A services/preferences/public/cpp/tracked/configuration.h View 1 chunk +37 lines, -0 lines 0 comments Download
A services/preferences/public/cpp/tracked/configuration.cc View 1 1 chunk +25 lines, -0 lines 0 comments Download
A + services/preferences/public/cpp/tracked/mock_validation_delegate.h View 7 chunks +31 lines, -23 lines 0 comments Download
A + services/preferences/public/cpp/tracked/mock_validation_delegate.cc View 4 chunks +21 lines, -16 lines 0 comments Download
A + services/preferences/public/cpp/tracked/pref_names.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/preferences/public/cpp/tracked/pref_names.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/preferences/public/cpp/tracked/tracked_preference_histogram_names.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/preferences/public/cpp/tracked/tracked_preference_histogram_names.cc View 1 chunk +1 line, -1 line 0 comments Download
D services/preferences/public/cpp/tracked_preference_validation_delegate.typemap View 1 chunk +0 lines, -14 lines 0 comments Download
D services/preferences/public/cpp/tracked_preference_validation_delegate_struct_traits.h View 1 chunk +0 lines, -28 lines 0 comments Download
D services/preferences/public/cpp/tracked_preference_validation_delegate_struct_traits.cc View 1 chunk +0 lines, -69 lines 0 comments Download
M services/preferences/public/cpp/typemaps.gni View 1 chunk +1 line, -4 lines 0 comments Download
M services/preferences/public/interfaces/preferences_configuration.mojom View 1 1 chunk +25 lines, -0 lines 0 comments Download
A + services/preferences/tracked/BUILD.gn View 1 2 3 5 chunks +10 lines, -22 lines 0 comments Download
A services/preferences/tracked/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A + services/preferences/tracked/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/preferences/tracked/device_id.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/preferences/tracked/device_id_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/preferences/tracked/device_id_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/preferences/tracked/device_id_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/preferences/tracked/device_id_win.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
A + services/preferences/tracked/dictionary_hash_store_contents.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + services/preferences/tracked/dictionary_hash_store_contents.cc View 2 chunks +2 lines, -3 lines 0 comments Download
A + services/preferences/tracked/hash_store_contents.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/preferences/tracked/interceptable_pref_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/preferences/tracked/interceptable_pref_filter.cc View 1 chunk +3 lines, -5 lines 0 comments Download
A + services/preferences/tracked/pref_hash_calculator.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/preferences/tracked/pref_hash_calculator.cc View 2 chunks +2 lines, -3 lines 0 comments Download
A + services/preferences/tracked/pref_hash_calculator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/preferences/tracked/pref_hash_filter.h View 5 chunks +15 lines, -39 lines 0 comments Download
A + services/preferences/tracked/pref_hash_filter.cc View 6 chunks +24 lines, -29 lines 0 comments Download
A + services/preferences/tracked/pref_hash_filter_unittest.cc View 1 34 chunks +102 lines, -122 lines 0 comments Download
A + services/preferences/tracked/pref_hash_store.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + services/preferences/tracked/pref_hash_store_impl.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + services/preferences/tracked/pref_hash_store_impl.cc View 9 chunks +23 lines, -21 lines 0 comments Download
A + services/preferences/tracked/pref_hash_store_impl_unittest.cc View 23 chunks +58 lines, -69 lines 0 comments Download
A + services/preferences/tracked/pref_hash_store_transaction.h View 5 chunks +11 lines, -33 lines 0 comments Download
A + services/preferences/tracked/registry_hash_store_contents_win.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + services/preferences/tracked/registry_hash_store_contents_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + services/preferences/tracked/registry_hash_store_contents_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/preferences/tracked/segregated_pref_store.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/preferences/tracked/segregated_pref_store.cc View 2 chunks +2 lines, -3 lines 0 comments Download
A + services/preferences/tracked/segregated_pref_store_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
A + services/preferences/tracked/tracked_atomic_preference.h View 4 chunks +9 lines, -8 lines 0 comments Download
A + services/preferences/tracked/tracked_atomic_preference.cc View 4 chunks +11 lines, -12 lines 0 comments Download
A + services/preferences/tracked/tracked_preference.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/preferences/tracked/tracked_preference_helper.h View 3 chunks +18 lines, -13 lines 0 comments Download
A + services/preferences/tracked/tracked_preference_helper.cc View 1 2 3 4 2 chunks +30 lines, -27 lines 0 comments Download
A + services/preferences/tracked/tracked_preferences_migration.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + services/preferences/tracked/tracked_preferences_migration.cc View 8 chunks +15 lines, -24 lines 0 comments Download
A + services/preferences/tracked/tracked_preferences_migration_unittest.cc View 12 chunks +41 lines, -51 lines 0 comments Download
A + services/preferences/tracked/tracked_split_preference.h View 4 chunks +9 lines, -8 lines 0 comments Download
A + services/preferences/tracked/tracked_split_preference.cc View 5 chunks +13 lines, -13 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 69 (55 generated)
Sam McNally
3 years, 8 months ago (2017-03-29 05:30:53 UTC) #4
tibell
lgtm
3 years, 8 months ago (2017-03-29 05:58:50 UTC) #5
gab
This is great, thanks! PS: Would have been nice to make the enums into enum ...
3 years, 8 months ago (2017-03-29 16:27:57 UTC) #6
Sam McNally
+blundell for //components/BUILD.gn +robertshield for //chrome/browser/safe_browsing/incident_reporting +mbarbella for mojom, typemap and traits +agl for //services/preferences/tracked/DEPS ...
3 years, 8 months ago (2017-03-30 02:23:23 UTC) #30
blundell
lgtm for //components/BUILD.gn
3 years, 8 months ago (2017-03-30 07:27:11 UTC) #33
gab
https://codereview.chromium.org/2782803002/diff/140001/chrome/browser/prefs/profile_pref_store_manager_unittest.cc File chrome/browser/prefs/profile_pref_store_manager_unittest.cc (right): https://codereview.chromium.org/2782803002/diff/140001/chrome/browser/prefs/profile_pref_store_manager_unittest.cc#newcode332 chrome/browser/prefs/profile_pref_store_manager_unittest.cc:332: ReloadConfiguration(); Why is this now required? Add a comment ...
3 years, 8 months ago (2017-03-30 14:56:34 UTC) #34
robertshield
LGTM for chrome/browser/safe_browsing/incident_reporting/
3 years, 8 months ago (2017-03-30 15:05:57 UTC) #35
Sam McNally
https://codereview.chromium.org/2782803002/diff/140001/chrome/browser/prefs/profile_pref_store_manager_unittest.cc File chrome/browser/prefs/profile_pref_store_manager_unittest.cc (right): https://codereview.chromium.org/2782803002/diff/140001/chrome/browser/prefs/profile_pref_store_manager_unittest.cc#newcode332 chrome/browser/prefs/profile_pref_store_manager_unittest.cc:332: ReloadConfiguration(); On 2017/03/30 14:56:34, gab wrote: > Why is ...
3 years, 8 months ago (2017-03-31 02:55:51 UTC) #48
Martin Barbella
lgtm
3 years, 8 months ago (2017-03-31 15:12:26 UTC) #53
Sam McNally
TBR=agl@chromium.org for the DEPS move.
3 years, 8 months ago (2017-04-03 01:15:08 UTC) #59
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782803002/240001
3 years, 8 months ago (2017-04-03 01:15:37 UTC) #62
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/400726)
3 years, 8 months ago (2017-04-03 01:24:18 UTC) #64
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782803002/240001
3 years, 8 months ago (2017-04-03 01:51:35 UTC) #66
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 01:58:08 UTC) #69
Message was sent while issue was closed.
Committed patchset #5 (id:240001) as
https://chromium.googlesource.com/chromium/src/+/fb473a87fb9a0cb77a7081150592...

Powered by Google App Engine
This is Rietveld 408576698