Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: services/preferences/tracked/tracked_atomic_preference.cc

Issue 2782803002: Move tracked prefs into services/preferences/tracked. (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/user_prefs/tracked/tracked_atomic_preference.h" 5 #include "services/preferences/tracked/tracked_atomic_preference.h"
6 6
7 #include "base/values.h" 7 #include "base/values.h"
8 #include "components/user_prefs/tracked/pref_hash_store_transaction.h"
9 #include "services/preferences/public/interfaces/tracked_preference_validation_d elegate.mojom.h" 8 #include "services/preferences/public/interfaces/tracked_preference_validation_d elegate.mojom.h"
9 #include "services/preferences/tracked/pref_hash_store_transaction.h"
10
11 using ValueState =
12 prefs::mojom::TrackedPreferenceValidationDelegate::ValueState;
10 13
11 TrackedAtomicPreference::TrackedAtomicPreference( 14 TrackedAtomicPreference::TrackedAtomicPreference(
12 const std::string& pref_path, 15 const std::string& pref_path,
13 size_t reporting_id, 16 size_t reporting_id,
14 size_t reporting_ids_count, 17 size_t reporting_ids_count,
15 PrefHashFilter::EnforcementLevel enforcement_level, 18 prefs::mojom::TrackedPreferenceMetadata::EnforcementLevel enforcement_level,
16 PrefHashFilter::ValueType value_type, 19 prefs::mojom::TrackedPreferenceMetadata::ValueType value_type,
17 prefs::mojom::TrackedPreferenceValidationDelegate* delegate) 20 prefs::mojom::TrackedPreferenceValidationDelegate* delegate)
18 : pref_path_(pref_path), 21 : pref_path_(pref_path),
19 helper_(pref_path, 22 helper_(pref_path,
20 reporting_id, 23 reporting_id,
21 reporting_ids_count, 24 reporting_ids_count,
22 enforcement_level, 25 enforcement_level,
23 value_type), 26 value_type),
24 delegate_(delegate) {} 27 delegate_(delegate) {}
25 28
26 TrackedPreferenceType TrackedAtomicPreference::GetType() const { 29 TrackedPreferenceType TrackedAtomicPreference::GetType() const {
27 return TrackedPreferenceType::ATOMIC; 30 return TrackedPreferenceType::ATOMIC;
28 } 31 }
29 32
30 void TrackedAtomicPreference::OnNewValue( 33 void TrackedAtomicPreference::OnNewValue(
31 const base::Value* value, 34 const base::Value* value,
32 PrefHashStoreTransaction* transaction) const { 35 PrefHashStoreTransaction* transaction) const {
33 transaction->StoreHash(pref_path_, value); 36 transaction->StoreHash(pref_path_, value);
34 } 37 }
35 38
36 bool TrackedAtomicPreference::EnforceAndReport( 39 bool TrackedAtomicPreference::EnforceAndReport(
37 base::DictionaryValue* pref_store_contents, 40 base::DictionaryValue* pref_store_contents,
38 PrefHashStoreTransaction* transaction, 41 PrefHashStoreTransaction* transaction,
39 PrefHashStoreTransaction* external_validation_transaction) const { 42 PrefHashStoreTransaction* external_validation_transaction) const {
40 const base::Value* value = NULL; 43 const base::Value* value = NULL;
41 pref_store_contents->Get(pref_path_, &value); 44 pref_store_contents->Get(pref_path_, &value);
42 PrefHashStoreTransaction::ValueState value_state = 45 ValueState value_state = transaction->CheckValue(pref_path_, value);
43 transaction->CheckValue(pref_path_, value);
44 helper_.ReportValidationResult(value_state, transaction->GetStoreUMASuffix()); 46 helper_.ReportValidationResult(value_state, transaction->GetStoreUMASuffix());
45 47
46 PrefHashStoreTransaction::ValueState external_validation_value_state = 48 ValueState external_validation_value_state = ValueState::UNSUPPORTED;
47 PrefHashStoreTransaction::UNSUPPORTED;
48 if (external_validation_transaction) { 49 if (external_validation_transaction) {
49 external_validation_value_state = 50 external_validation_value_state =
50 external_validation_transaction->CheckValue(pref_path_, value); 51 external_validation_transaction->CheckValue(pref_path_, value);
51 helper_.ReportValidationResult( 52 helper_.ReportValidationResult(
52 external_validation_value_state, 53 external_validation_value_state,
53 external_validation_transaction->GetStoreUMASuffix()); 54 external_validation_transaction->GetStoreUMASuffix());
54 } 55 }
55 56
56 if (delegate_) { 57 if (delegate_) {
57 delegate_->OnAtomicPreferenceValidation( 58 delegate_->OnAtomicPreferenceValidation(
58 pref_path_, value ? value->CreateDeepCopy() : nullptr, value_state, 59 pref_path_, value ? value->CreateDeepCopy() : nullptr, value_state,
59 external_validation_value_state, helper_.IsPersonal()); 60 external_validation_value_state, helper_.IsPersonal());
60 } 61 }
61 TrackedPreferenceHelper::ResetAction reset_action = 62 TrackedPreferenceHelper::ResetAction reset_action =
62 helper_.GetAction(value_state); 63 helper_.GetAction(value_state);
63 helper_.ReportAction(reset_action); 64 helper_.ReportAction(reset_action);
64 65
65 bool was_reset = false; 66 bool was_reset = false;
66 if (reset_action == TrackedPreferenceHelper::DO_RESET) { 67 if (reset_action == TrackedPreferenceHelper::DO_RESET) {
67 pref_store_contents->RemovePath(pref_path_, NULL); 68 pref_store_contents->RemovePath(pref_path_, NULL);
68 was_reset = true; 69 was_reset = true;
69 } 70 }
70 71
71 if (value_state != PrefHashStoreTransaction::UNCHANGED) { 72 if (value_state != ValueState::UNCHANGED) {
72 // Store the hash for the new value (whether it was reset or not). 73 // Store the hash for the new value (whether it was reset or not).
73 const base::Value* new_value = NULL; 74 const base::Value* new_value = NULL;
74 pref_store_contents->Get(pref_path_, &new_value); 75 pref_store_contents->Get(pref_path_, &new_value);
75 transaction->StoreHash(pref_path_, new_value); 76 transaction->StoreHash(pref_path_, new_value);
76 } 77 }
77 78
78 // Update MACs in the external store if there is one and there either was a 79 // Update MACs in the external store if there is one and there either was a
79 // reset or external validation failed. 80 // reset or external validation failed.
80 if (external_validation_transaction && 81 if (external_validation_transaction &&
81 (was_reset || 82 (was_reset || external_validation_value_state != ValueState::UNCHANGED)) {
82 external_validation_value_state !=
83 PrefHashStoreTransaction::UNCHANGED)) {
84 const base::Value* new_value = nullptr; 83 const base::Value* new_value = nullptr;
85 pref_store_contents->Get(pref_path_, &new_value); 84 pref_store_contents->Get(pref_path_, &new_value);
86 external_validation_transaction->StoreHash(pref_path_, new_value); 85 external_validation_transaction->StoreHash(pref_path_, new_value);
87 } 86 }
88 87
89 return was_reset; 88 return was_reset;
90 } 89 }
OLDNEW
« no previous file with comments | « services/preferences/tracked/tracked_atomic_preference.h ('k') | services/preferences/tracked/tracked_preference.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698