Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 2782583002: Deduplicate testharness test names in LayoutTests/svg/ (Closed)

Created:
3 years, 8 months ago by fs
Modified:
3 years, 8 months ago
Reviewers:
Stephen Chennney
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Deduplicate testharness test names in LayoutTests/svg/ Some tests were using non-unique names, which triggers a harness error for "newer" versions of testharness.js. Twiddle the relevant names a bit so that they become unique. BUG=705626 Review-Url: https://codereview.chromium.org/2782583002 Cr-Commit-Position: refs/heads/master@{#460447} Committed: https://chromium.googlesource.com/chromium/src/+/e9637327dcc73c3d4abc94874d353e093436fe49

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1046 lines) Patch
M third_party/WebKit/LayoutTests/svg/css/baseline-shift-inherit.html View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/svg/css/baseline-shift-inherit-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/css/path-element.html View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/svg/css/path-element-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/getBBox-circle-has-one-zero-value.html View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/svg/custom/getBBox-circle-has-one-zero-value-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/getBBox-ellipse-has-one-zero-value.html View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/svg/custom/getBBox-ellipse-has-one-zero-value-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/getBBox-rect-has-one-zero-value.html View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/svg/custom/getBBox-rect-has-one-zero-value-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/svgangle-units.html View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/svgangle-units-expected.txt View 1 chunk +0 lines, -795 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/tabindex-focus.html View 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/tabindex-focus-expected.txt View 1 chunk +0 lines, -172 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/in-html/sizing/svg-inline-vertical.html View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/in-html/sizing/svg-inline-vertical-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
fs
3 years, 8 months ago (2017-03-28 14:56:20 UTC) #5
Stephen Chennney
Thanks for doing this. lgtm
3 years, 8 months ago (2017-03-29 16:40:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782583002/1
3 years, 8 months ago (2017-03-29 16:41:37 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 17:50:10 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e9637327dcc73c3d4abc94874d35...

Powered by Google App Engine
This is Rietveld 408576698