Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1089)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 2782483002: Disable -Wl,--gdb-index with LTO. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/chromecast_build.gni") 7 import("//build/config/chromecast_build.gni")
8 import("//build/config/compiler/compiler.gni") 8 import("//build/config/compiler/compiler.gni")
9 import("//build/config/nacl/config.gni") 9 import("//build/config/nacl/config.gni")
10 import("//build/toolchain/cc_wrapper.gni") 10 import("//build/toolchain/cc_wrapper.gni")
(...skipping 1643 matching lines...) Expand 10 before | Expand all | Expand 10 after
1654 cflags += [ "-gsplit-dwarf" ] 1654 cflags += [ "-gsplit-dwarf" ]
1655 } 1655 }
1656 asmflags = cflags 1656 asmflags = cflags
1657 ldflags = [] 1657 ldflags = []
1658 1658
1659 # TODO(thakis): Figure out if there's a way to make this go for 32-bit, 1659 # TODO(thakis): Figure out if there's a way to make this go for 32-bit,
1660 # currently we get "warning: 1660 # currently we get "warning:
1661 # obj/native_client/src/trusted/service_runtime/sel_asm/nacl_switch_32.o: 1661 # obj/native_client/src/trusted/service_runtime/sel_asm/nacl_switch_32.o:
1662 # DWARF info may be corrupt; offsets in a range list entry are in different 1662 # DWARF info may be corrupt; offsets in a range list entry are in different
1663 # sections" there. Maybe just a bug in nacl_switch_32.S. 1663 # sections" there. Maybe just a bug in nacl_switch_32.S.
1664 if (!is_mac && !is_ios && !is_nacl && target_cpu != "x86") { 1664 # TODO(thakis): Figure out if there's a way to make this go for official
1665 # builds, currently get
1666 # "third_party/binutils/Linux_x64/Release/bin/ld.gold: warning:
1667 # /tmp/lto-llvm-0b5201.o: corrupt debug info in .debug_info"
1668 if (!is_mac && !is_ios && !is_nacl && target_cpu != "x86" &&
1669 !is_official_build) {
krasin1 2017/03/28 17:03:38 This is not probably what we want here. We need to
1665 ldflags += [ "-Wl,--gdb-index" ] 1670 ldflags += [ "-Wl,--gdb-index" ]
1666 } 1671 }
1667 } 1672 }
1668 } 1673 }
1669 1674
1670 # Minimal symbols. 1675 # Minimal symbols.
1671 config("minimal_symbols") { 1676 config("minimal_symbols") {
1672 if (is_win) { 1677 if (is_win) {
1673 # Linker symbols for backtraces only. 1678 # Linker symbols for backtraces only.
1674 cflags = [] 1679 cflags = []
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
1715 1720
1716 if (is_ios || is_mac) { 1721 if (is_ios || is_mac) {
1717 # On Mac and iOS, this enables support for ARC (automatic ref-counting). 1722 # On Mac and iOS, this enables support for ARC (automatic ref-counting).
1718 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html. 1723 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
1719 config("enable_arc") { 1724 config("enable_arc") {
1720 common_flags = [ "-fobjc-arc" ] 1725 common_flags = [ "-fobjc-arc" ]
1721 cflags_objc = common_flags 1726 cflags_objc = common_flags
1722 cflags_objcc = common_flags 1727 cflags_objcc = common_flags
1723 } 1728 }
1724 } 1729 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698