Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2782353002:
[MD settings] add padding under title line in subpages (Closed)
|
Created:
3 years, 8 months ago by dschuyler Modified:
3 years, 8 months ago CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[MD settings] add padding under title line in subpages
This CL adds some padding under the title line in settings subpages, as
requested by UX (bettes@).
BUG=706630
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2782353002
Cr-Commit-Position: refs/heads/master@{#460877}
Committed: https://chromium.googlesource.com/chromium/src/+/62cbb3b5b6b96422f82ce810ff457ed56b8237c1
Patch Set 1 #
Total comments: 5
Messages
Total messages: 24 (12 generated)
Description was changed from ========== [MD settings] add padding under title line in subpages This CL adds some padding under the title line in settings subpages, as requested by UX (bettes@). BUG=706630 ========== to ========== [MD settings] add padding under title line in subpages This CL adds some padding under the title line in settings subpages, as requested by UX (bettes@). BUG=706630 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
dschuyler@chromium.org changed reviewers: + scottchen@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder probably lacks capacity)
On 2017/03/29 23:47:31, dschuyler wrote: could you upload a before/after screenshot? I was under the impression that bettes@ wanted padding-bottom under the first toggle row as part of the "and also make it blue when toggle is on" change, instead of adding padding under the title.
On 2017/03/30 06:45:50, scottchen wrote: > On 2017/03/29 23:47:31, dschuyler wrote: > > could you upload a before/after screenshot? I was under the impression that > bettes@ wanted padding-bottom under the first toggle row as part of the "and > also make it blue when toggle is on" change, instead of adding padding under the > title. I added after shots to the bug. Before shots will take a bit more time.
On 2017/03/30 18:21:28, dschuyler wrote: > On 2017/03/30 06:45:50, scottchen wrote: > > On 2017/03/29 23:47:31, dschuyler wrote: > > > > could you upload a before/after screenshot? I was under the impression that > > bettes@ wanted padding-bottom under the first toggle row as part of the "and > > also make it blue when toggle is on" change, instead of adding padding under > the > > title. > > I added after shots to the bug. Before shots will take a bit more time. lgtm
The CQ bit was checked by dschuyler@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
dschuyler@chromium.org changed reviewers: + tommycli@chromium.org
lgtm. My comments below can be in a separate CL, the same CL, or never if you prefer... https://codereview.chromium.org/2782353002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_page/settings_subpage.html (right): https://codereview.chromium.org/2782353002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_page/settings_subpage.html:21: .settings-box.first { I assume this rule is only supposed to apply to that one div right? in that case i'd suggest an id instead https://codereview.chromium.org/2782353002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_page/settings_subpage.html:27: .settings-box.first > h1 { And this is only supposed to apply to that h1 page title also right? I also suggest an id instead.
Totally reasonable suggestions. Likely in another CL. https://codereview.chromium.org/2782353002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_page/settings_subpage.html (right): https://codereview.chromium.org/2782353002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_page/settings_subpage.html:21: .settings-box.first { On 2017/03/30 20:35:08, tommycli wrote: > I assume this rule is only supposed to apply to that one div right? in that case > i'd suggest an id instead Acknowledged. https://codereview.chromium.org/2782353002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_page/settings_subpage.html:27: .settings-box.first > h1 { On 2017/03/30 20:35:08, tommycli wrote: > And this is only supposed to apply to that h1 page title also right? I also > suggest an id instead. Acknowledged.
The CQ bit was checked by dschuyler@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2782353002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_page/settings_subpage.html (right): https://codereview.chromium.org/2782353002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_page/settings_subpage.html:21: .settings-box.first { On 2017/03/30 20:48:41, dschuyler wrote: > On 2017/03/30 20:35:08, tommycli wrote: > > I assume this rule is only supposed to apply to that one div right? in that > case > > i'd suggest an id instead > > Acknowledged. See https://codereview.chromium.org/2787923002/
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490907624692960, "parent_rev":
"88a1aa7a6141160af77f9829f64b17c3c6cda5ee", "commit_rev":
"62cbb3b5b6b96422f82ce810ff457ed56b8237c1"}
Message was sent while issue was closed.
Description was changed from ========== [MD settings] add padding under title line in subpages This CL adds some padding under the title line in settings subpages, as requested by UX (bettes@). BUG=706630 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] add padding under title line in subpages This CL adds some padding under the title line in settings subpages, as requested by UX (bettes@). BUG=706630 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2782353002 Cr-Commit-Position: refs/heads/master@{#460877} Committed: https://chromium.googlesource.com/chromium/src/+/62cbb3b5b6b96422f82ce810ff45... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/62cbb3b5b6b96422f82ce810ff45... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
