Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Side by Side Diff: chrome/browser/resources/settings/settings_page/settings_subpage.html

Issue 2782353002: [MD settings] add padding under title line in subpages (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l"> 2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l">
3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-resizable-behavior /iron-resizable-behavior.html"> 3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-resizable-behavior /iron-resizable-behavior.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable-behavior.html"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable-behavior.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-ripple/paper-ripp le.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-ripple/paper-ripp le.html">
7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-spinner/paper-spi nner.html"> 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-spinner/paper-spi nner.html">
8 <link rel="import" href="../icons.html"> 8 <link rel="import" href="../icons.html">
9 <link rel="import" href="../route.html"> 9 <link rel="import" href="../route.html">
10 <link rel="import" href="settings_subpage_search.html"> 10 <link rel="import" href="settings_subpage_search.html">
11 <link rel="import" href="../settings_shared_css.html"> 11 <link rel="import" href="../settings_shared_css.html">
12 12
13 <dom-module id="settings-subpage"> 13 <dom-module id="settings-subpage">
14 <template> 14 <template>
15 <style include="settings-shared"> 15 <style include="settings-shared">
16 :host { 16 :host {
17 display: block; 17 display: block;
18 padding-bottom: 60px; 18 padding-bottom: 60px;
19 } 19 }
20 20
21 .settings-box.first { 21 .settings-box.first {
tommycli 2017/03/30 20:35:08 I assume this rule is only supposed to apply to th
dschuyler 2017/03/30 20:48:41 Acknowledged.
dschuyler 2017/03/30 21:03:36 See https://codereview.chromium.org/2787923002/
22 min-height: 40px; 22 min-height: 40px;
23 padding-bottom: 24px;
23 padding-top: 8px; 24 padding-top: 8px;
24 } 25 }
25 26
26 .settings-box.first > h1 { 27 .settings-box.first > h1 {
tommycli 2017/03/30 20:35:08 And this is only supposed to apply to that h1 page
dschuyler 2017/03/30 20:48:41 Acknowledged.
27 -webkit-margin-start: 4px; 28 -webkit-margin-start: 4px;
28 } 29 }
29 30
30 #learnMore { 31 #learnMore {
31 @apply(--cr-paper-icon-button-margin); 32 @apply(--cr-paper-icon-button-margin);
32 align-items: center; 33 align-items: center;
33 display: flex; 34 display: flex;
34 height: var(--cr-icon-ripple-size); 35 height: var(--cr-icon-ripple-size);
35 justify-content: center; 36 justify-content: center;
36 position: relative; /* Needed for paper-ripple. */ 37 position: relative; /* Needed for paper-ripple. */
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 </settings-subpage-search> 79 </settings-subpage-search>
79 </template> 80 </template>
80 <template is="dom-if" if="[[showSpinner]]"> 81 <template is="dom-if" if="[[showSpinner]]">
81 <paper-spinner active></paper-spinner> 82 <paper-spinner active></paper-spinner>
82 </template> 83 </template>
83 </div> 84 </div>
84 <content></content> 85 <content></content>
85 </template> 86 </template>
86 <script src="settings_subpage.js"></script> 87 <script src="settings_subpage.js"></script>
87 </dom-module> 88 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698