Store local border box property cache outside ObjectPaintProperties

Store local border box property cache outside ObjectPaintProperties

This patch moves the local border box property cache out of
ObjectPaintProperties so it can be managed separately. Data in
crbug.com/700452 [1] shows that LocalBorderBoxProperties is needed
much more than ObjectPaintProperties so this will save memory.

The big change here is to move LocalBorderBoxProperties from
ObjectPaintProperties to LayoutObject::RarePaintData. Because
the contents properties cache depends on the local border box
properties, it has also been moved to RarePaintData.

This patch reduces memory on youtube.com by 106.7KB [1].

[1] https://docs.google.com/spreadsheets/d/1IC1JI0sX7QsR9FmA4G1-F9E_c3xRKDNoV3SkDKQ822U

BUG=700452
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2782343002
Cr-Commit-Position: refs/heads/master@{#461340}
Committed: https://chromium.googlesource.com/chromium/src/+/4b973463f5203e58f12e363703026d6acb808026

[pdr., 2017-03-29 23:27:13]

Description was changed from

==========
Store local border box property cache outside ObjectPaintProperties

This patch moves the local border box property cache out of
ObjectPaintProperties so it can be managed separately. Data in
crbug.com/700452 shows that LocalBorderBoxProperties is needed
much more than ObjectPaintProperties so this will save memory.

The big change here is to move LocalBorderBoxProperties from
ObjectPaintProperties to LayoutObject::RarePaintData. Because
the contents properties cache depends on the local border box
properties, it has also been moved to RarePaintData.

BUG=700452
==========

to

==========
Store local border box property cache outside ObjectPaintProperties

This patch moves the local border box property cache out of
ObjectPaintProperties so it can be managed separately. Data in
crbug.com/700452 shows that LocalBorderBoxProperties is needed
much more than ObjectPaintProperties so this will save memory.

The big change here is to move LocalBorderBoxProperties from
ObjectPaintProperties to LayoutObject::RarePaintData. Because
the contents properties cache depends on the local border box
properties, it has also been moved to RarePaintData.

BUG=700452
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[pdr., 2017-03-29 23:29:31]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[pdr., 2017-03-29 23:30:02]

pdr@chromium.org changed reviewers:
+ chrishtr@chromium.org, wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-03-29 23:30:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2017-03-29 23:35:09]

Description was changed from

==========
Store local border box property cache outside ObjectPaintProperties

This patch moves the local border box property cache out of
ObjectPaintProperties so it can be managed separately. Data in
crbug.com/700452 shows that LocalBorderBoxProperties is needed
much more than ObjectPaintProperties so this will save memory.

The big change here is to move LocalBorderBoxProperties from
ObjectPaintProperties to LayoutObject::RarePaintData. Because
the contents properties cache depends on the local border box
properties, it has also been moved to RarePaintData.

BUG=700452
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Store local border box property cache outside ObjectPaintProperties

This patch moves the local border box property cache out of
ObjectPaintProperties so it can be managed separately. Data in
crbug.com/700452 [1] shows that LocalBorderBoxProperties is needed
much more than ObjectPaintProperties so this will save memory.

The big change here is to move LocalBorderBoxProperties from
ObjectPaintProperties to LayoutObject::RarePaintData. Because
the contents properties cache depends on the local border box
properties, it has also been moved to RarePaintData.

[1]
https://docs.google.com/spreadsheets/d/1IC1JI0sX7QsR9FmA4G1-F9E_c3xRKDNoV3SkD...

BUG=700452
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2017-03-29 23:35:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 23:35:15]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[pdr., 2017-03-30 00:13:47]

https://codereview.chromium.org/2782343002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/2782343002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:3591:
m_contentsProperties = ObjectPaintProperties::contentsProperties(
I don't like how this patch puts paint logic in LayoutObject. I tried to reduce
this with ObjectPaintProperties::contentsProperties but LayoutObject still knows
too much about paint. I think I'll move RarePaintData to a separate file in a
followup.

[Xianzhu, 2017-03-30 00:41:11]

lgtm

https://codereview.chromium.org/2782343002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/2782343002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:3559:
m_contentsProperties(nullptr) {}
Nit: omit this to use default constructor of unique_ptr?

[pdr., 2017-04-02 01:21:10]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-02 01:21:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2017-04-02 02:38:12]

Description was changed from

==========
Store local border box property cache outside ObjectPaintProperties

This patch moves the local border box property cache out of
ObjectPaintProperties so it can be managed separately. Data in
crbug.com/700452 [1] shows that LocalBorderBoxProperties is needed
much more than ObjectPaintProperties so this will save memory.

The big change here is to move LocalBorderBoxProperties from
ObjectPaintProperties to LayoutObject::RarePaintData. Because
the contents properties cache depends on the local border box
properties, it has also been moved to RarePaintData.

[1]
https://docs.google.com/spreadsheets/d/1IC1JI0sX7QsR9FmA4G1-F9E_c3xRKDNoV3SkD...

BUG=700452
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Store local border box property cache outside ObjectPaintProperties

This patch moves the local border box property cache out of
ObjectPaintProperties so it can be managed separately. Data in
crbug.com/700452 [1] shows that LocalBorderBoxProperties is needed
much more than ObjectPaintProperties so this will save memory.

The big change here is to move LocalBorderBoxProperties from
ObjectPaintProperties to LayoutObject::RarePaintData. Because
the contents properties cache depends on the local border box
properties, it has also been moved to RarePaintData.

This patch reduces memory on youtube.com by 106.7KB [1].

[1]
https://docs.google.com/spreadsheets/d/1IC1JI0sX7QsR9FmA4G1-F9E_c3xRKDNoV3SkD...

BUG=700452
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2017-04-02 04:06:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-02 04:06:41]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[pdr., 2017-04-02 04:11:07]

The CQ bit was checked by pdr@chromium.org

[pdr., 2017-04-02 04:11:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2782343002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-02 04:11:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-02 05:57:39]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1491106267458140,
"parent_rev": "42770766f680dc08f99dd01b8dfb5c7153d90e5b", "commit_rev":
"4b973463f5203e58f12e363703026d6acb808026"}

[commit-bot: I haz the power, 2017-04-02 05:59:00]

Description was changed from

==========
Store local border box property cache outside ObjectPaintProperties

This patch moves the local border box property cache out of
ObjectPaintProperties so it can be managed separately. Data in
crbug.com/700452 [1] shows that LocalBorderBoxProperties is needed
much more than ObjectPaintProperties so this will save memory.

The big change here is to move LocalBorderBoxProperties from
ObjectPaintProperties to LayoutObject::RarePaintData. Because
the contents properties cache depends on the local border box
properties, it has also been moved to RarePaintData.

This patch reduces memory on youtube.com by 106.7KB [1].

[1]
https://docs.google.com/spreadsheets/d/1IC1JI0sX7QsR9FmA4G1-F9E_c3xRKDNoV3SkD...

BUG=700452
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Store local border box property cache outside ObjectPaintProperties

This patch moves the local border box property cache out of
ObjectPaintProperties so it can be managed separately. Data in
crbug.com/700452 [1] shows that LocalBorderBoxProperties is needed
much more than ObjectPaintProperties so this will save memory.

The big change here is to move LocalBorderBoxProperties from
ObjectPaintProperties to LayoutObject::RarePaintData. Because
the contents properties cache depends on the local border box
properties, it has also been moved to RarePaintData.

This patch reduces memory on youtube.com by 106.7KB [1].

[1]
https://docs.google.com/spreadsheets/d/1IC1JI0sX7QsR9FmA4G1-F9E_c3xRKDNoV3SkD...

BUG=700452
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2782343002
Cr-Commit-Position: refs/heads/master@{#461340}
Committed:
https://chromium.googlesource.com/chromium/src/+/4b973463f5203e58f12e36370302...
==========

[commit-bot: I haz the power, 2017-04-02 05:59:01]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/4b973463f5203e58f12e36370302...