Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

Issue 2782343002: Store local border box property cache outside ObjectPaintProperties (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
index abcaf8ad5b6885d1bb20970f12d0e52e533a58d9..62c79947d539e11a3f3b27ee4a95158bd4735da7 100644
--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
@@ -684,14 +684,13 @@ void PaintPropertyTreeBuilder::updateLocalBorderBoxContext(
if (!object.needsPaintPropertyUpdate() && !context.forceSubtreeUpdate)
return;
- // We need localBorderBoxProperties for layered objects only.
+ // We only need to cache the local border box properties for layered objects.
if (!object.hasLayer()) {
- if (auto* properties = object.getMutableForPainting().paintProperties())
- properties->clearLocalBorderBoxProperties();
+ object.getMutableForPainting().clearLocalBorderBoxProperties();
} else {
- auto& properties = object.getMutableForPainting().ensurePaintProperties();
- properties.updateLocalBorderBoxProperties(
+ PropertyTreeState localBorderBox = PropertyTreeState(
context.current.transform, context.current.clip, context.currentEffect);
+ object.getMutableForPainting().setLocalBorderBoxProperties(localBorderBox);
}
}

Powered by Google App Engine
This is Rietveld 408576698