[Web Payments] Constrain the dialog inner views to parent's width

[Web Payments] Constrain the dialog inner views to parent's width

BUG=697921
Review-Url: https://codereview.chromium.org/2782303002
Cr-Commit-Position: refs/heads/master@{#460579}
Committed: https://chromium.googlesource.com/chromium/src/+/87569a5ed05e1e4c04625819bad26ba0a232b0c3

[anthonyvd, 2017-03-29 21:50:14]

The CQ bit was checked by anthonyvd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 21:51:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[anthonyvd, 2017-03-29 21:52:21]

anthonyvd@chromium.org changed reviewers:
+ mathp@chromium.org

[anthonyvd, 2017-03-29 21:52:21]

Hi Math,

This patch wraps the content of the dialog in a view of the width of the dialog
to avoid having long content overflow horizontally.

Can you PTAL? Thanks!

[Mathieu, 2017-03-29 22:03:08]

lgtm thanks!

https://codereview.chromium.org/2782303002/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/payment_request_views_util.h (right):

https://codereview.chromium.org/2782303002/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/payment_request_views_util.h:37: constexpr int
kDialogWidth = 450;
BTW I think harmony dialog widths are being standardized? Something to keep an
eye on:

https://codereview.chromium.org/2785683003/

[anthonyvd, 2017-03-29 22:10:27]

https://codereview.chromium.org/2782303002/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/payment_request_views_util.h (right):

https://codereview.chromium.org/2782303002/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/payment_request_views_util.h:37: constexpr int
kDialogWidth = 450;
On 2017/03/29 at 22:03:08, Mathieu wrote:
> BTW I think harmony dialog widths are being standardized? Something to keep an
eye on:
> 
> https://codereview.chromium.org/2785683003/

Good to know! I'll land this as-is, monitor the other CL, and see what we need
to change to take this into account.

[anthonyvd, 2017-03-29 23:04:48]

The CQ bit was unchecked by anthonyvd@chromium.org

[anthonyvd, 2017-03-29 23:04:50]

The CQ bit was checked by anthonyvd@chromium.org

[commit-bot: I haz the power, 2017-03-29 23:06:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 23:35:58]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490828690070440, "parent_rev":
"78965a2abbe5d4365204bbc46933a523144a1eb7", "commit_rev":
"87569a5ed05e1e4c04625819bad26ba0a232b0c3"}

[commit-bot: I haz the power, 2017-03-29 23:36:39]

Description was changed from

==========
[Web Payments] Constrain the dialog inner views to parent's width

BUG=697921
==========

to

==========
[Web Payments] Constrain the dialog inner views to parent's width

BUG=697921

Review-Url: https://codereview.chromium.org/2782303002
Cr-Commit-Position: refs/heads/master@{#460579}
Committed:
https://chromium.googlesource.com/chromium/src/+/87569a5ed05e1e4c04625819bad2...
==========

[commit-bot: I haz the power, 2017-03-29 23:36:40]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/87569a5ed05e1e4c04625819bad2...