Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Side by Side Diff: chrome/browser/ui/views/payments/payment_request_views_util.h

Issue 2782303002: [Web Payments] Constrain the dialog inner views to parent's width (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/views/payments/payment_request_sheet_controller.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_PAYMENTS_PAYMENT_REQUEST_VIEWS_UTIL_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_PAYMENTS_PAYMENT_REQUEST_VIEWS_UTIL_H_
6 #define CHROME_BROWSER_UI_VIEWS_PAYMENTS_PAYMENT_REQUEST_VIEWS_UTIL_H_ 6 #define CHROME_BROWSER_UI_VIEWS_PAYMENTS_PAYMENT_REQUEST_VIEWS_UTIL_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 10
(...skipping 15 matching lines...) Expand all
26 namespace payments { 26 namespace payments {
27 27
28 constexpr int kPaymentRequestRowHorizontalInsets = 16; 28 constexpr int kPaymentRequestRowHorizontalInsets = 16;
29 constexpr int kPaymentRequestRowVerticalInsets = 8; 29 constexpr int kPaymentRequestRowVerticalInsets = 8;
30 30
31 // Extra inset relative to the header when a right edge should line up with the 31 // Extra inset relative to the header when a right edge should line up with the
32 // close button's X rather than its invisible right edge. 32 // close button's X rather than its invisible right edge.
33 constexpr int kPaymentRequestRowExtraRightInset = 8; 33 constexpr int kPaymentRequestRowExtraRightInset = 8;
34 constexpr int kPaymentRequestButtonSpacing = 10; 34 constexpr int kPaymentRequestButtonSpacing = 10;
35 35
36 // Dimensions of the dialog itself.
37 constexpr int kDialogWidth = 450;
Mathieu 2017/03/29 22:03:08 BTW I think harmony dialog widths are being standa
anthonyvd 2017/03/29 22:10:27 Good to know! I'll land this as-is, monitor the ot
38 constexpr int kDialogHeight = 450;
39
36 enum class PaymentRequestCommonTags { 40 enum class PaymentRequestCommonTags {
37 BACK_BUTTON_TAG = 0, 41 BACK_BUTTON_TAG = 0,
38 CLOSE_BUTTON_TAG, 42 CLOSE_BUTTON_TAG,
39 PAY_BUTTON_TAG, 43 PAY_BUTTON_TAG,
40 // This is the max value of tags for controls common to multiple 44 // This is the max value of tags for controls common to multiple
41 // PaymentRequest contexts. Individual screens that handle both common and 45 // PaymentRequest contexts. Individual screens that handle both common and
42 // specific events with tags can start their specific tags at this value. 46 // specific events with tags can start their specific tags at this value.
43 PAYMENT_REQUEST_COMMON_TAG_MAX 47 PAYMENT_REQUEST_COMMON_TAG_MAX
44 }; 48 };
45 49
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 base::string16 GetShippingOptionSectionString( 100 base::string16 GetShippingOptionSectionString(
97 payments::mojom::PaymentShippingType shipping_type); 101 payments::mojom::PaymentShippingType shipping_type);
98 102
99 std::unique_ptr<views::View> CreateShippingOptionLabel( 103 std::unique_ptr<views::View> CreateShippingOptionLabel(
100 payments::mojom::PaymentShippingOption* shipping_option, 104 payments::mojom::PaymentShippingOption* shipping_option,
101 const base::string16& formatted_amount); 105 const base::string16& formatted_amount);
102 106
103 } // namespace payments 107 } // namespace payments
104 108
105 #endif // CHROME_BROWSER_UI_VIEWS_PAYMENTS_PAYMENT_REQUEST_VIEWS_UTIL_H_ 109 #endif // CHROME_BROWSER_UI_VIEWS_PAYMENTS_PAYMENT_REQUEST_VIEWS_UTIL_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/payments/payment_request_sheet_controller.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698