Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2782093003: Merge "Form validation: Validation bubble should be closed on document unload process." to M58 (Closed)

Created:
3 years, 8 months ago by tkent
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Merge "Form validation: Validation bubble should be closed on document unload process." to M58 This CL fixes a bug that a validation bubble is not closed by page navigation in some cases. We close a validation message on Page::documentDetached(). However it seems it was too late to communicate with the browser process in some cases. So, this CL moves it to Document unload timing. * Add ValidationMessage::willUnloadDocument(), which closes a validation bubble, and Document::dispatchUnloadEvents() calls it indirectly through Page. * HTMLFormControlElement prevents from showing a validation message after the unload processing. BUG=704560 Review-Url: https://codereview.chromium.org/2771193002 Cr-Commit-Position: refs/heads/master@{#459701} (cherry picked from commit a896ff44a395a50ab18f5120f20b7eb5a9550247) Review-Url: https://codereview.chromium.org/2782093003 . Cr-Commit-Position: refs/branch-heads/3029@{#472} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/2bf11fe64e121ef8c9603d1b56e972b4800cc3c0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -2 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentTest.cpp View 3 chunks +77 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/Page.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/ValidationMessageClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ValidationMessageClientImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
tkent
3 years, 8 months ago (2017-03-29 07:55:09 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2bf11fe64e121ef8c9603d1b56e972b4800cc3c0.

Powered by Google App Engine
This is Rietveld 408576698