Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3657)

Unified Diff: build/config/compiler/compiler.gni

Issue 2782063005: Explicitly specify whether to emit frame pointers by default. (Closed)
Patch Set: Rebase. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/compiler/compiler.gni
diff --git a/build/config/compiler/compiler.gni b/build/config/compiler/compiler.gni
index 66c65e0550ab2b788e714662c2e401bb211a3b92..71b832b73a7517139844323c783b2deeb63d8b55 100644
--- a/build/config/compiler/compiler.gni
+++ b/build/config/compiler/compiler.gni
@@ -63,6 +63,19 @@ declare_args() {
use_pic = true
}
+# Whether to emit frame pointers by default. Targets can override this to change
+# the behavior.
+if (is_mac || is_ios || is_win) {
+ enabled_frame_pointers = true
+} else {
+ # Explicitly ask for frame pointers, otherwise:
+ # * Stacks may be missing for sanitizer and profiling builds.
+ # * Debug tcmalloc can crash (crbug.com/636489).
+ # * Stacks may be missing for arm64 crash dumps (crbug.com/391706).
+ enabled_frame_pointers =
+ using_sanitizer || enable_profiling || is_debug || current_cpu == "arm64"
Mark Mentovai 2017/03/30 23:43:29 Maybe this takes care of it? I’m not really a GN g
+}
+
declare_args() {
# Whether or not the official builds should be built with full WPO. Enabled by
# default for the PGO and the x64 builds.

Powered by Google App Engine
This is Rietveld 408576698