Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/chromeos/libc_close_tracking.cc

Issue 2782063005: Explicitly specify whether to emit frame pointers by default. (Closed)
Patch Set: Rebase. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/config/compiler/compiler.gni ('K') | « build/config/compiler/compiler.gni ('k') | tools/gn/bootstrap/bootstrap.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/libc_close_tracking.cc
diff --git a/chrome/browser/chromeos/libc_close_tracking.cc b/chrome/browser/chromeos/libc_close_tracking.cc
index 260a116b5a2e664ed3e7064d42af3ccc765f6882..28e13d34be883f289546d17de538700e5abf44d9 100644
--- a/chrome/browser/chromeos/libc_close_tracking.cc
+++ b/chrome/browser/chromeos/libc_close_tracking.cc
@@ -119,7 +119,7 @@ int CloseOverride(int fd) {
// Capture stack for successful close.
if (ret == 0) {
-#if HAVE_TRACE_STACK_FRAME_POINTERS && !defined(MEMORY_SANITIZER)
+#if CAN_UNWIND_WITH_FRAME_POINTERS && !defined(MEMORY_SANITIZER)
// Use TraceStackFramePointers because the backtrack() based default
// capturing gets only the last stack frame and is not useful.
// With the exception of when MSAN is enabled. See comments for why
« build/config/compiler/compiler.gni ('K') | « build/config/compiler/compiler.gni ('k') | tools/gn/bootstrap/bootstrap.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698