Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1262)

Side by Side Diff: build/config/compiler/compiler.gni

Issue 2782063005: Explicitly specify whether to emit frame pointers by default. (Closed)
Patch Set: Rebase. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/chromecast_build.gni") 7 import("//build/config/chromecast_build.gni")
8 import("//build/config/compiler/pgo/pgo.gni") 8 import("//build/config/compiler/pgo/pgo.gni")
9 import("//build/config/sanitizers/sanitizers.gni") 9 import("//build/config/sanitizers/sanitizers.gni")
10 import("//build/toolchain/goma.gni") 10 import("//build/toolchain/goma.gni")
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 # Note that doing a link repro uses a lot of disk space and slows down the 56 # Note that doing a link repro uses a lot of disk space and slows down the
57 # build, so this shouldn't be enabled on too many targets. 57 # build, so this shouldn't be enabled on too many targets.
58 # 58 #
59 # See crbug.com/669854. 59 # See crbug.com/669854.
60 linkrepro_root_dir = "" 60 linkrepro_root_dir = ""
61 61
62 # Whether or not we should use position independent code. 62 # Whether or not we should use position independent code.
63 use_pic = true 63 use_pic = true
64 } 64 }
65 65
66 # Whether to emit frame pointers by default. Targets can override this to change
67 # the behavior.
68 if (is_mac || is_ios || is_win) {
69 enabled_frame_pointers = true
70 } else {
71 # Explicitly ask for frame pointers, otherwise:
72 # * Stacks may be missing for sanitizer and profiling builds.
73 # * Debug tcmalloc can crash (crbug.com/636489).
74 # * Stacks may be missing for arm64 crash dumps (crbug.com/391706).
75 enabled_frame_pointers =
76 using_sanitizer || enable_profiling || is_debug || current_cpu == "arm64"
Mark Mentovai 2017/03/30 23:43:29 Maybe this takes care of it? I’m not really a GN g
77 }
78
66 declare_args() { 79 declare_args() {
67 # Whether or not the official builds should be built with full WPO. Enabled by 80 # Whether or not the official builds should be built with full WPO. Enabled by
68 # default for the PGO and the x64 builds. 81 # default for the PGO and the x64 builds.
69 if (chrome_pgo_phase > 0) { 82 if (chrome_pgo_phase > 0) {
70 full_wpo_on_official = true 83 full_wpo_on_official = true
71 } else { 84 } else {
72 full_wpo_on_official = false 85 full_wpo_on_official = false
73 } 86 }
74 } 87 }
75 88
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 } 138 }
126 139
127 # Assert that the configuration isn't going to hit https://crbug.com/648948. 140 # Assert that the configuration isn't going to hit https://crbug.com/648948.
128 assert(ignore_elf32_limitations || !is_android || 141 assert(ignore_elf32_limitations || !is_android ||
129 (android_64bit_target_cpu && !build_apk_secondary_abi) || 142 (android_64bit_target_cpu && !build_apk_secondary_abi) ||
130 is_component_build || symbol_level < 2, 143 is_component_build || symbol_level < 2,
131 "Android 32-bit non-component builds cannot have symbol_level=2 " + 144 "Android 32-bit non-component builds cannot have symbol_level=2 " +
132 "due to 4GiB file size limit, see https://crbug.com/648948. " + 145 "due to 4GiB file size limit, see https://crbug.com/648948. " +
133 "If you really want to try this out, " + 146 "If you really want to try this out, " +
134 "set ignore_elf32_limitations=true.") 147 "set ignore_elf32_limitations=true.")
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698