[inspector] prepared console before moving into builtins

[inspector] prepared console before moving into builtins

We need to split creating of console and installing memory getter and remove console.assert hack before migration to builtin. We can implement super fast console.assert after migration.

BUG=chromium:588893
R=dgozman@chromium.org
TBR=yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2781883003
Cr-Commit-Position: refs/heads/master@{#44256}
Committed: https://chromium.googlesource.com/v8/v8/+/872accf9df751534053a60c0572802e1a5e10402

[kozy, 2017-03-29 00:17:40]

Dmitry, please take a look.

[kozy, 2017-03-29 00:19:14]

Description was changed from

==========
[inspector] prepared console before moving into builtins

We need to split creating of console and installing memory getter and removed
console.assert hack. We can implement super fast console.assert later after
migrationg finished.

BUG=chromium:588893
R=dgozman@chromium.org
==========

to

==========
[inspector] prepared console before moving into builtins

We need to split creating of console and installing memory getter and remove
console.assert hack before migration to builtin. We can implement super fast
console.assert later after migrationg finished.

BUG=chromium:588893
R=dgozman@chromium.org
==========

[kozy, 2017-03-29 00:19:26]

Description was changed from

==========
[inspector] prepared console before moving into builtins

We need to split creating of console and installing memory getter and remove
console.assert hack before migration to builtin. We can implement super fast
console.assert later after migrationg finished.

BUG=chromium:588893
R=dgozman@chromium.org
==========

to

==========
[inspector] prepared console before moving into builtins

We need to split creating of console and installing memory getter and remove
console.assert hack before migration to builtin. We can implement super fast
console.assert later after.

BUG=chromium:588893
R=dgozman@chromium.org
==========

[kozy, 2017-03-29 00:19:47]

Description was changed from

==========
[inspector] prepared console before moving into builtins

We need to split creating of console and installing memory getter and remove
console.assert hack before migration to builtin. We can implement super fast
console.assert later after.

BUG=chromium:588893
R=dgozman@chromium.org
==========

to

==========
[inspector] prepared console before moving into builtins

We need to split creating of console and installing memory getter and remove
console.assert hack before migration to builtin. We can implement super fast
console.assert after migration.

BUG=chromium:588893
R=dgozman@chromium.org
==========

[dgozman, 2017-03-29 20:34:41]

lgtm

[kozy, 2017-03-29 22:17:15]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2017-03-29 22:17:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 22:34:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 22:34:35]

Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_linux64_verify_csa_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)

[kozy, 2017-03-29 22:37:25]

Description was changed from

==========
[inspector] prepared console before moving into builtins

We need to split creating of console and installing memory getter and remove
console.assert hack before migration to builtin. We can implement super fast
console.assert after migration.

BUG=chromium:588893
R=dgozman@chromium.org
==========

to

==========
[inspector] prepared console before moving into builtins

We need to split creating of console and installing memory getter and remove
console.assert hack before migration to builtin. We can implement super fast
console.assert after migration.

BUG=chromium:588893
R=dgozman@chromium.org
TBR=yangguo@chromium.org
==========

[kozy, 2017-03-29 22:37:25]

kozyatinskiy@chromium.org changed reviewers:
+ yangguo@chromium.org

[kozy, 2017-03-29 22:37:29]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-03-29 22:37:30]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2781883003/#ps60001
(title: "fixed debug-script test")

[commit-bot: I haz the power, 2017-03-29 22:37:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 23:04:50]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490827049959180,
"parent_rev": "85d731e930c16b048bef14af941d1010c04b0759", "commit_rev":
"872accf9df751534053a60c0572802e1a5e10402"}

[commit-bot: I haz the power, 2017-03-29 23:04:55]

Description was changed from

==========
[inspector] prepared console before moving into builtins

We need to split creating of console and installing memory getter and remove
console.assert hack before migration to builtin. We can implement super fast
console.assert after migration.

BUG=chromium:588893
R=dgozman@chromium.org
TBR=yangguo@chromium.org
==========

to

==========
[inspector] prepared console before moving into builtins

We need to split creating of console and installing memory getter and remove
console.assert hack before migration to builtin. We can implement super fast
console.assert after migration.

BUG=chromium:588893
R=dgozman@chromium.org
TBR=yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2781883003
Cr-Commit-Position: refs/heads/master@{#44256}
Committed:
https://chromium.googlesource.com/v8/v8/+/872accf9df751534053a60c0572802e1a5e...
==========

[commit-bot: I haz the power, 2017-03-29 23:04:58]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/872accf9df751534053a60c0572802e1a5e...