Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Unified Diff: src/inspector/inspected-context.cc

Issue 2781883003: [inspector] prepared console before moving into builtins (Closed)
Patch Set: fixed debug-script test Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/inspector/v8-console.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/inspected-context.cc
diff --git a/src/inspector/inspected-context.cc b/src/inspector/inspected-context.cc
index 7f00721908b9b2b713cf818ac1b65dc9f9d68b40..8fd0aadca2726346d21376cb495918488300800d 100644
--- a/src/inspector/inspected-context.cc
+++ b/src/inspector/inspected-context.cc
@@ -28,8 +28,10 @@ InspectedContext::InspectedContext(V8InspectorImpl* inspector,
info.context->SetEmbedderData(static_cast<int>(v8::Context::kDebugIdIndex),
v8::Int32::New(isolate, contextId));
v8::Local<v8::Object> global = info.context->Global();
- v8::Local<v8::Object> console =
- V8Console::createConsole(this, info.hasMemoryOnConsole);
+ v8::Local<v8::Object> console = V8Console::createConsole(this);
+ if (info.hasMemoryOnConsole) {
+ V8Console::installMemoryGetter(m_inspector, info.context, console);
+ }
if (!global
->Set(info.context, toV8StringInternalized(isolate, "console"),
console)
« no previous file with comments | « no previous file | src/inspector/v8-console.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698