Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Issue 2781863002: Revert of Update the passthrough command decoder to use the new CHROMIUM_copy_texture. (Closed)

Created:
3 years, 8 months ago by Geoff Lang
Modified:
3 years, 8 months ago
Reviewers:
piman
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, piman+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update the passthrough command decoder to use the new CHROMIUM_copy_texture. (patchset #2 id:20001 of https://codereview.chromium.org/2776753002/ ) Reason for revert: ANGLE vulkan layers roll broke Windows builders. Original issue's description: > Update the passthrough command decoder to use the new CHROMIUM_copy_texture. > > Clean up the extension spec to not use GL prefixes. > > Fix the missmatch between using GLuint and GLenum for texture IDs. > > BUG=612542 > BUG=angleproject:1932 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2776753002 > Cr-Commit-Position: refs/heads/master@{#460105} > Committed: https://chromium.googlesource.com/chromium/src/+/e8f6d1aee5378201806dcf6c0dc4fde3dabb60a1 TBR=piman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=612542 Review-Url: https://codereview.chromium.org/2781863002 Cr-Commit-Position: refs/heads/master@{#460114} Committed: https://chromium.googlesource.com/chromium/src/+/95cf7a59de278ede5e772ba752215c80a80ed122

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -389 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt View 4 chunks +106 lines, -156 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 3 chunks +6 lines, -6 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 3 chunks +5 lines, -5 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 3 chunks +5 lines, -5 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_impl_autogen.h View 5 chunks +20 lines, -17 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_autogen.h View 2 chunks +6 lines, -6 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_autogen.h View 2 chunks +5 lines, -5 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h View 3 chunks +6 lines, -6 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_autogen.h View 2 chunks +5 lines, -5 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h View 3 chunks +6 lines, -6 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 5 chunks +10 lines, -10 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 4 chunks +11 lines, -11 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 3 chunks +6 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doer_prototypes.h View 2 chunks +5 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc View 3 chunks +11 lines, -13 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers_autogen.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M ui/gl/generate_bindings.py View 2 chunks +7 lines, -8 lines 0 comments Download
M ui/gl/gl_bindings_api_autogen_gl.h View 2 chunks +0 lines, -6 lines 0 comments Download
M ui/gl/gl_bindings_autogen_gl.h View 4 chunks +0 lines, -12 lines 0 comments Download
M ui/gl/gl_bindings_autogen_gl.cc View 11 chunks +22 lines, -52 lines 0 comments Download
M ui/gl/gl_bindings_autogen_mock.h View 2 chunks +0 lines, -6 lines 0 comments Download
M ui/gl/gl_bindings_autogen_mock.cc View 3 chunks +5 lines, -12 lines 0 comments Download
M ui/gl/gl_mock.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/gl/gl_mock_autogen_gl.h View 2 chunks +9 lines, -12 lines 0 comments Download
M ui/gl/gl_stub_autogen_gl.h View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Geoff Lang
Created Revert of Update the passthrough command decoder to use the new CHROMIUM_copy_texture.
3 years, 8 months ago (2017-03-28 15:43:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781863002/1
3 years, 8 months ago (2017-03-28 15:44:18 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 15:46:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/95cf7a59de278ede5e772ba75221...

Powered by Google App Engine
This is Rietveld 408576698