Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2776753002: Update the passthrough command decoder to use the new CHROMIUM_copy_texture. (Closed)

Created:
3 years, 9 months ago by Geoff Lang
Modified:
3 years, 8 months ago
Reviewers:
piman
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, piman+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the passthrough command decoder to use the new CHROMIUM_copy_texture. Clean up the extension spec to not use GL prefixes. Fix the missmatch between using GLuint and GLenum for texture IDs. Roll ANGLE 4063e20..795e757 https://chromium.googlesource.com/angle/angle.git/+log/4063e20..795e757 BUG=612542 BUG=angleproject:1932 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2776753002 Cr-Original-Commit-Position: refs/heads/master@{#460105} Committed: https://chromium.googlesource.com/chromium/src/+/e8f6d1aee5378201806dcf6c0dc4fde3dabb60a1 Review-Url: https://codereview.chromium.org/2776753002 Cr-Commit-Position: refs/heads/master@{#460166} Committed: https://chromium.googlesource.com/chromium/src/+/8ff20f23f09ac7211555bbe9f519cf49c9bfe0e7

Patch Set 1 #

Patch Set 2 : Roll ANGLE #

Patch Set 3 : Re-roll ANGLE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+382 lines, -259 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt View 4 chunks +149 lines, -99 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 3 chunks +6 lines, -6 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 3 chunks +5 lines, -5 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 3 chunks +5 lines, -5 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_impl_autogen.h View 5 chunks +17 lines, -20 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_autogen.h View 2 chunks +6 lines, -6 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_autogen.h View 2 chunks +5 lines, -5 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h View 3 chunks +6 lines, -6 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_autogen.h View 2 chunks +5 lines, -5 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h View 3 chunks +6 lines, -6 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 5 chunks +10 lines, -10 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 4 chunks +11 lines, -11 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 3 chunks +6 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doer_prototypes.h View 2 chunks +5 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc View 1 3 chunks +13 lines, -11 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers_autogen.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M ui/gl/generate_bindings.py View 2 chunks +8 lines, -7 lines 0 comments Download
M ui/gl/gl_bindings_api_autogen_gl.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/gl/gl_bindings_autogen_gl.h View 4 chunks +12 lines, -0 lines 0 comments Download
M ui/gl/gl_bindings_autogen_gl.cc View 11 chunks +52 lines, -22 lines 0 comments Download
M ui/gl/gl_bindings_autogen_mock.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/gl/gl_bindings_autogen_mock.cc View 3 chunks +12 lines, -5 lines 0 comments Download
M ui/gl/gl_mock.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gl/gl_mock_autogen_gl.h View 2 chunks +12 lines, -9 lines 0 comments Download
M ui/gl/gl_stub_autogen_gl.h View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
Geoff Lang
PTAL, going to roll ANGLE at the same time updating the function prototypes there.
3 years, 9 months ago (2017-03-27 13:37:20 UTC) #8
piman
LGTM. Thanks for the cleanup!
3 years, 9 months ago (2017-03-27 18:17:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776753002/20001
3 years, 8 months ago (2017-03-28 14:02:01 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/e8f6d1aee5378201806dcf6c0dc4fde3dabb60a1
3 years, 8 months ago (2017-03-28 15:18:00 UTC) #15
Geoff Lang
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2781863002/ by geofflang@chromium.org. ...
3 years, 8 months ago (2017-03-28 15:43:33 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776753002/40001
3 years, 8 months ago (2017-03-28 16:12:26 UTC) #21
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 18:01:59 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8ff20f23f09ac7211555bbe9f519...

Powered by Google App Engine
This is Rietveld 408576698