Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2781853002: Revert of Log created probe clusters to RtcEventLog. (Closed)

Created:
3 years, 8 months ago by philipel
Modified:
3 years, 8 months ago
Reviewers:
terelius, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Log created probe clusters to RtcEventLog. (patchset #1 id:1 of https://codereview.chromium.org/2783693002/ ) Reason for revert: Break bots. Original issue's description: > Reland of Log created probe clusters to RtcEventLog. (patchset #1 id:1 of https://codereview.chromium.org/2775273003/ ) > > Reason for revert: > Speculative reland since it apparently built on https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/22852 > > Original issue's description: > > Revert of Log created probe clusters to RtcEventLog. (patchset #3 id:40001 of https://codereview.chromium.org/2776073003/ ) > > > > Reason for revert: > > Break build bots. > > > > Original issue's description: > > > Log created probe clusters to RtcEventLog. > > > > > > BUG=webrtc:6984 > > > > > > Review-Url: https://codereview.webrtc.org/2776073003 > > > Cr-Commit-Position: refs/heads/master@{#17413} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/bb9e6edc327bb2aa03fdc3b480925727d9831f9e > > > > TBR=terelius@webrtc.org,stefan@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:6984 > > > > Review-Url: https://codereview.webrtc.org/2775273003 > > Cr-Commit-Position: refs/heads/master@{#17415} > > Committed: https://chromium.googlesource.com/external/webrtc/+/7ac5c32db2cfea33c4fc7cda4950c491fcf58ded > > TBR=terelius@webrtc.org,stefan@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6984 > > Review-Url: https://codereview.webrtc.org/2783693002 > Cr-Commit-Position: refs/heads/master@{#17424} > Committed: https://chromium.googlesource.com/external/webrtc/+/2a63160b95a62ee137712b8fa28763ee58ca641e TBR=terelius@webrtc.org,stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6984 Review-Url: https://codereview.webrtc.org/2781853002 Cr-Commit-Position: refs/heads/master@{#17425} Committed: https://chromium.googlesource.com/external/webrtc/+/e3b354bdfa234b7525c0c8cbbe2d6d2f84fb9930

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -33 lines) Patch
M webrtc/modules/congestion_controller/send_side_congestion_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/pacing/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/pacing/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/pacing/bitrate_prober.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/pacing/bitrate_prober.cc View 3 chunks +2 lines, -11 lines 0 comments Download
M webrtc/modules/pacing/mock/mock_paced_sender.h View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/pacing/paced_sender.h View 2 chunks +1 line, -4 lines 0 comments Download
M webrtc/modules/pacing/paced_sender.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/modules/pacing/paced_sender_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/packet_sender.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
philipel
Created Revert of Log created probe clusters to RtcEventLog.
3 years, 8 months ago (2017-03-28 14:59:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2781853002/1
3 years, 8 months ago (2017-03-28 14:59:48 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/e3b354bdfa234b7525c0c8cbbe2d6d2f84fb9930
3 years, 8 months ago (2017-03-28 14:59:55 UTC) #6
philipel
3 years, 8 months ago (2017-03-28 15:22:44 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2779893004/ by philipel@webrtc.org.

The reason for reverting is: Fix.

Powered by Google App Engine
This is Rietveld 408576698