Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2779893004: Reland of Log created probe clusters to RtcEventLog. (Closed)

Created:
3 years, 8 months ago by philipel
Modified:
3 years, 8 months ago
Reviewers:
terelius, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Log created probe clusters to RtcEventLog. (patchset #1 id:1 of https://codereview.chromium.org/2781853002/ ) Reason for revert: Fix Original issue's description: > Revert of Log created probe clusters to RtcEventLog. (patchset #1 id:1 of https://codereview.chromium.org/2783693002/ ) > > Reason for revert: > Break bots. > > Original issue's description: ... > > TBR=terelius@webrtc.org,stefan@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6984 > > Review-Url: https://codereview.webrtc.org/2781853002 > Cr-Commit-Position: refs/heads/master@{#17425} > Committed: https://chromium.googlesource.com/external/webrtc/+/e3b354bdfa234b7525c0c8cbbe2d6d2f84fb9930 TBR=terelius@webrtc.org,stefan@webrtc.org BUG=webrtc:6984 Review-Url: https://codereview.webrtc.org/2779893004 Cr-Commit-Position: refs/heads/master@{#17433} Committed: https://chromium.googlesource.com/external/webrtc/+/c3b3f7a8aab848337a72735077e4407bbde0f29a

Patch Set 1 #

Patch Set 2 : Dependency fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -14 lines) Patch
M webrtc/modules/congestion_controller/send_side_congestion_controller.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/pacing/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/pacing/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/pacing/bitrate_prober.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/modules/pacing/bitrate_prober.cc View 1 3 chunks +11 lines, -2 lines 0 comments Download
M webrtc/modules/pacing/mock/mock_paced_sender.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/pacing/paced_sender.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M webrtc/modules/pacing/paced_sender.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/modules/pacing/paced_sender_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/packet_sender.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (8 generated)
philipel
Created Reland of Log created probe clusters to RtcEventLog.
3 years, 8 months ago (2017-03-28 15:22:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2779893004/230001
3 years, 8 months ago (2017-03-29 08:20:01 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 08:23:17 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:230001) as
https://chromium.googlesource.com/external/webrtc/+/c3b3f7a8aab848337a7273507...

Powered by Google App Engine
This is Rietveld 408576698