Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 2781833003: Only use overlays on windows 10 anniversary update and later. (Closed)

Created:
3 years, 8 months ago by jbauman
Modified:
3 years, 8 months ago
Reviewers:
scottmg
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Only use overlays on windows 10 anniversary update and later. Before this Chrome would never be assigned overlays so trying to use them won't save power. BUG=678800 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2781833003 Cr-Commit-Position: refs/heads/master@{#460663} Committed: https://chromium.googlesource.com/chromium/src/+/8c39bf0cbed618be0e6b040be0bf7bed36a9384d

Patch Set 1 #

Patch Set 2 : add new version enum #

Total comments: 2

Patch Set 3 : update gpu histogram usage #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M base/win/windows_version.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M base/win/windows_version.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M gpu/ipc/service/direct_composition_surface_win.cc View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (21 generated)
jbauman
3 years, 8 months ago (2017-03-29 02:07:11 UTC) #9
scottmg
lgtm https://codereview.chromium.org/2781833003/diff/20001/gpu/ipc/service/direct_composition_surface_win.cc File gpu/ipc/service/direct_composition_surface_win.cc (right): https://codereview.chromium.org/2781833003/diff/20001/gpu/ipc/service/direct_composition_surface_win.cc#newcode78 gpu/ipc/service/direct_composition_surface_win.cc:78: return true; Did you mean to put it ...
3 years, 8 months ago (2017-03-29 03:16:03 UTC) #10
jbauman
https://codereview.chromium.org/2781833003/diff/20001/gpu/ipc/service/direct_composition_surface_win.cc File gpu/ipc/service/direct_composition_surface_win.cc (right): https://codereview.chromium.org/2781833003/diff/20001/gpu/ipc/service/direct_composition_surface_win.cc#newcode78 gpu/ipc/service/direct_composition_surface_win.cc:78: return true; On 2017/03/29 03:16:02, scottmg wrote: > Did ...
3 years, 8 months ago (2017-03-29 18:55:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781833003/40001
3 years, 8 months ago (2017-03-29 21:56:48 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/398038)
3 years, 8 months ago (2017-03-29 22:12:15 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781833003/60001
3 years, 8 months ago (2017-03-30 03:14:13 UTC) #25
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 04:23:36 UTC) #28
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8c39bf0cbed618be0e6b040be0bf...

Powered by Google App Engine
This is Rietveld 408576698