MD Settings: Fix case where 'REMOVE ALL SHOWN' button is erroneously shown.

MD Settings: Fix case where 'REMOVE ALL SHOWN' button is erroneously shown.

BUG=705441
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2781703002
Cr-Commit-Position: refs/heads/master@{#460214}
Committed: https://chromium.googlesource.com/chromium/src/+/ff5026c59eda509f6f73caee29a4b36042d2e4f9

[dpapad, 2017-03-27 20:12:32]

Description was changed from

==========
MD Settings: Fix case where 'REMOVE ALL SHOWN' button is erroneously shown.

BUG=705441
==========

to

==========
MD Settings: Fix case where 'REMOVE ALL SHOWN' button is erroneously shown.

BUG=705441
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-03-27 23:06:11]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 23:06:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-03-27 23:11:42]

dpapad@chromium.org changed reviewers:
+ dschuyler@chromium.org

[commit-bot: I haz the power, 2017-03-28 00:33:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 00:33:23]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2017-03-28 19:18:23]

https://codereview.chromium.org/2781703002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_data.html (right):

https://codereview.chromium.org/2781703002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_data.html:49:
rendered-item-count="{{renderedItemCount::dom-change}}"
Will this trigger/update more often than it did before, and/or is that likely to
be an issue? My concern is that dom-change may be spammy and this may slow
things down. If it's the same or better (or if there is no feasible alternative)
then this would be ok.

[dpapad, 2017-03-28 19:27:40]

On 2017/03/28 at 19:18:23, dschuyler wrote:
>
https://codereview.chromium.org/2781703002/diff/40001/chrome/browser/resource...
> File chrome/browser/resources/settings/site_settings/site_data.html (right):
> 
>
https://codereview.chromium.org/2781703002/diff/40001/chrome/browser/resource...
> chrome/browser/resources/settings/site_settings/site_data.html:49:
rendered-item-count="{{renderedItemCount::dom-change}}"
> Will this trigger/update more often than it did before, and/or is that likely
to be an issue? My concern is that dom-change may be spammy and this may slow
things down. If it's the same or better (or if there is no feasible alternative)
then this would be ok.

My experiment showed that this triggers exactly the same amount of callbacks as
before, so I don't think it can be an issue. The alternative is to fix the core
Polymer issue at https://github.com/Polymer/polymer/issues/4465, but per my
understanding, this will make no difference in performance at all. It will
simply allow us to remove the "::dom-change" part from the binding syntax.

[dschuyler, 2017-03-28 19:29:26]

Thanks for the explanation. That makes sense. lgtm

[dpapad, 2017-03-28 20:32:21]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2017-03-28 20:33:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 20:47:55]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490733141305840,
"parent_rev": "6ebe3d3956bc508f81d14025654bf15482d6f5b6", "commit_rev":
"ff5026c59eda509f6f73caee29a4b36042d2e4f9"}

[commit-bot: I haz the power, 2017-03-28 20:49:12]

Description was changed from

==========
MD Settings: Fix case where 'REMOVE ALL SHOWN' button is erroneously shown.

BUG=705441
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix case where 'REMOVE ALL SHOWN' button is erroneously shown.

BUG=705441
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2781703002
Cr-Commit-Position: refs/heads/master@{#460214}
Committed:
https://chromium.googlesource.com/chromium/src/+/ff5026c59eda509f6f73caee29a4...
==========

[commit-bot: I haz the power, 2017-03-28 20:49:13]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ff5026c59eda509f6f73caee29a4...