Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Side by Side Diff: chrome/browser/resources/settings/site_settings/site_data.html

Issue 2781703002: MD Settings: Fix case where 'REMOVE ALL SHOWN' button is erroneously shown. (Closed)
Patch Set: Add test. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/site_data_test.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/i18n_behavior.html"> 1 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
2 <link rel="import" href="chrome://resources/html/polymer.html"> 2 <link rel="import" href="chrome://resources/html/polymer.html">
3 <link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html "> 3 <link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html ">
4 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 4 <link rel="import" href="chrome://resources/cr_elements/icons.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-f lex-layout-classes.html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-f lex-layout-classes.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l">
7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button-light.html"> 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button-light.html">
8 <link rel="import" href="../settings_page/settings_subpage_search.html"> 8 <link rel="import" href="../settings_page/settings_subpage_search.html">
9 <link rel="import" href="../settings_shared_css.html"> 9 <link rel="import" href="../settings_shared_css.html">
10 <link rel="import" href="cookie_tree_behavior.html"> 10 <link rel="import" href="cookie_tree_behavior.html">
(...skipping 28 matching lines...) Expand all
39 </div> 39 </div>
40 <div class="settings-box continuation"> 40 <div class="settings-box continuation">
41 <paper-button class="secondary-button" id="removeShowingSites" 41 <paper-button class="secondary-button" id="removeShowingSites"
42 on-tap="onRemoveShowingSitesTap_" 42 on-tap="onRemoveShowingSitesTap_"
43 hidden$="[[!isRemoveButtonVisible_(sites, renderedItemCount)]]"> 43 hidden$="[[!isRemoveButtonVisible_(sites, renderedItemCount)]]">
44 [[computeRemoveLabel_(filterString_)]] 44 [[computeRemoveLabel_(filterString_)]]
45 </paper-button> 45 </paper-button>
46 </div> 46 </div>
47 <div class="list-frame vertical-list"> 47 <div class="list-frame vertical-list">
48 <template is="dom-repeat" id="list" items="[[sites]]" filter="showItem_" 48 <template is="dom-repeat" id="list" items="[[sites]]" filter="showItem_"
49 rendered-item-count="{{renderedItemCount}}"> 49 rendered-item-count="{{renderedItemCount::dom-change}}"
dschuyler 2017/03/28 19:18:23 Will this trigger/update more often than it did be
50 notify-dom-change>
50 <div class="list-item two-line" on-tap="onSiteTap_" actionable> 51 <div class="list-item two-line" on-tap="onSiteTap_" actionable>
51 <div class="favicon-image" style$="[[computeSiteIcon(item.site)]]"> 52 <div class="favicon-image" style$="[[computeSiteIcon(item.site)]]">
52 </div> 53 </div>
53 <div class="middle"> 54 <div class="middle">
54 [[item.site]] 55 [[item.site]]
55 <div class="secondary" id="siteSecondary">[[item.localData]]</div> 56 <div class="secondary" id="siteSecondary">[[item.localData]]</div>
56 </div> 57 </div>
57 <button class="subpage-arrow" is="paper-icon-button-light" 58 <button class="subpage-arrow" is="paper-icon-button-light"
58 aria-label$="[[item.site]]" 59 aria-label$="[[item.site]]"
59 aria-describedby="siteSecondary"></button> 60 aria-describedby="siteSecondary"></button>
(...skipping 19 matching lines...) Expand all
79 <paper-button class="action-button" on-tap="onConfirmDelete_"> 80 <paper-button class="action-button" on-tap="onConfirmDelete_">
80 $i18n{siteSettingsCookiesClearAll} 81 $i18n{siteSettingsCookiesClearAll}
81 </paper-button> 82 </paper-button>
82 </div> 83 </div>
83 </dialog> 84 </dialog>
84 </template> 85 </template>
85 <script src="cookie_info.js"></script> 86 <script src="cookie_info.js"></script>
86 <script src="cookie_tree_node.js"></script> 87 <script src="cookie_tree_node.js"></script>
87 <script src="site_data.js"></script> 88 <script src="site_data.js"></script>
88 </dom-module> 89 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/site_data_test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698