[Devtools] DataGrid & ViewportDataGrid now should resetNode for children

[Devtools] DataGrid & ViewportDataGrid now should resetNode for children

This patch should ensure that ViewportDataGrid and DataGrid play nice
with eachother when removing and adding items to the dom. The core issue
was that _depth in DataGrid was not being cleared when handled by
ViewportDataGrid. This is not a long term solution, but is something
meant to let us get by until we can refactor DataGrid.

R=caseq,dgozman
BUG=696109
Review-Url: https://codereview.chromium.org/2781593003
Cr-Commit-Position: refs/heads/master@{#459959}
Committed: https://chromium.googlesource.com/chromium/src/+/8309530bfed7acbabd6a64adc53c5c7f2102e745

[allada, 2017-03-27 18:58:29]

PTL

[dgozman, 2017-03-27 21:15:24]

https://codereview.chromium.org/2781593003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js (left):

https://codereview.chromium.org/2781593003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js:1624:
child._depth = undefined;
Who does this now?

[allada, 2017-03-27 21:55:04]

https://codereview.chromium.org/2781593003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js (left):

https://codereview.chromium.org/2781593003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js:1624:
child._depth = undefined;
On 2017/03/27 21:15:23, dgozman wrote:
> Who does this now?

resetNode() "delete this._depth;"

[dgozman, 2017-03-27 22:47:02]

lgtm

https://codereview.chromium.org/2781593003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js (right):

https://codereview.chromium.org/2781593003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js:1650:
current._attached = false;
Don't need this.

[allada, 2017-03-27 23:18:24]

https://codereview.chromium.org/2781593003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js (right):

https://codereview.chromium.org/2781593003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js:1650:
current._attached = false;
On 2017/03/27 22:47:01, dgozman wrote:
> Don't need this.

In this case we do need it because we don't know if the child is hidden/not
shown yet. Below on line 1656 we attach everything if needed. We need to make
sure that the node gets refreshed in the DOM. I was going to add this to
resetNode() but it did not make sense on what was happening, since _attached is
not a cache... it's more like it's making itself "attachable" but not actually
changing it's structure.

[allada, 2017-03-27 23:18:30]

The CQ bit was checked by allada@chromium.org

[commit-bot: I haz the power, 2017-03-27 23:19:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 00:53:35]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490656710127270,
"parent_rev": "8c40265f143b45ecc7ddf49aedb363d6c7c70e69", "commit_rev":
"8309530bfed7acbabd6a64adc53c5c7f2102e745"}

[commit-bot: I haz the power, 2017-03-28 00:54:36]

Description was changed from

==========
[Devtools] DataGrid & ViewportDataGrid now should resetNode for children

This patch should ensure that ViewportDataGrid and DataGrid play nice
with eachother when removing and adding items to the dom. The core issue
was that _depth in DataGrid was not being cleared when handled by
ViewportDataGrid. This is not a long term solution, but is something
meant to let us get by until we can refactor DataGrid.

R=caseq,dgozman
BUG=696109
==========

to

==========
[Devtools] DataGrid & ViewportDataGrid now should resetNode for children

This patch should ensure that ViewportDataGrid and DataGrid play nice
with eachother when removing and adding items to the dom. The core issue
was that _depth in DataGrid was not being cleared when handled by
ViewportDataGrid. This is not a long term solution, but is something
meant to let us get by until we can refactor DataGrid.

R=caseq,dgozman
BUG=696109

Review-Url: https://codereview.chromium.org/2781593003
Cr-Commit-Position: refs/heads/master@{#459959}
Committed:
https://chromium.googlesource.com/chromium/src/+/8309530bfed7acbabd6a64adc53c...
==========

[commit-bot: I haz the power, 2017-03-28 00:54:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8309530bfed7acbabd6a64adc53c...