third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js - Issue 2781593003: [Devtools] DataGrid & ViewportDataGrid now should resetNode for children

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js

Issue 2781593003: [Devtools] DataGrid & ViewportDataGrid now should resetNode for children (Closed)

Patch Set: [Devtools] DataGrid & ViewportDataGrid now should resetNode for children Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js ('K') | « third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js

diff --git a/third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js b/third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js

index e9b5f7b1d48dc8e816d39bda8874e4179745f97d..df6f3304bf68509e202b69e792e52a5c46fc0a2b 100644

--- a/third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js

+++ b/third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js

@@ -372,8 +372,9 @@ DataGrid.ViewportDataGridNode = class extends DataGrid.DataGridNode {

if (child.parent !== this)

throw 'removeChild: Node is not a child of this node.';

- child._unlink();

this.children.remove(child, true);

+ child._unlink();

if (!this.children.length)

this.setHasChildren(false);

if (this._expanded)

@@ -400,10 +401,7 @@ DataGrid.ViewportDataGridNode = class extends DataGrid.DataGridNode {

this.existingElement().remove();

this.wasDetached();

}

- this.dataGrid = null;

- this.parent = null;

- this.nextSibling = null;

- this.previousSibling = null;

+ this.resetNode();

}

/**