Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1461)

Issue 2781393002: Test aborting an inactive Background Fetch registration (Closed)

Created:
3 years, 8 months ago by Peter Beverloo
Modified:
3 years, 8 months ago
Reviewers:
harkness
CC:
chromium-reviews, Peter Beverloo, darin-cc_chromium.org, jam, harkness+watch_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Test aborting an inactive Background Fetch registration This is valid per the IPC contract since developers can hold on to a registration even after cancelling it, so let's confirm that we bail out nicely without crashing. BUG= Review-Url: https://codereview.chromium.org/2781393002 Cr-Commit-Position: refs/heads/master@{#460816} Committed: https://chromium.googlesource.com/chromium/src/+/ea504d4d9555021596c5ad61740cbe5507d7a680

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -9 lines) Patch
M content/browser/background_fetch/background_fetch_service_unittest.cc View 1 chunk +19 lines, -9 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (4 generated)
harkness
lgtm
3 years, 8 months ago (2017-03-30 14:57:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781393002/1
3 years, 8 months ago (2017-03-30 17:10:56 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 17:48:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ea504d4d9555021596c5ad61740c...

Powered by Google App Engine
This is Rietveld 408576698